Page MenuHomePhabricator

[Keyserver] Use getCommConfig for tunnelbroker connection
ClosedPublic

Authored by kamil on Aug 25 2023, 1:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 6:40 PM
Unknown Object (File)
Sun, Nov 24, 4:34 PM
Unknown Object (File)
Oct 27 2024, 3:18 AM
Unknown Object (File)
Oct 27 2024, 3:18 AM
Unknown Object (File)
Oct 27 2024, 3:18 AM
Unknown Object (File)
Oct 27 2024, 3:18 AM
Unknown Object (File)
Oct 27 2024, 3:17 AM
Unknown Object (File)
Oct 27 2024, 3:07 AM
Subscribers

Details

Summary

Allow for the tunnelbroker endpoint to be configured. Necessary
for targeting production or staging instance during deployments.

https://linear.app/comm/issue/ENG-4706

Depends on D8956

Test Plan
cd keyserver
yarn dev # Should say defaulting to local instance
export COMM_JSONCONFIG_facts_tunnelbroker="{\"url\":\"ws://127.0.0.1:51001\"}"
yarn dev # Should omit default message, still connect to local instance

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D8752 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 25 2023, 1:13 PM
Harbormaster failed remote builds in B22098: Diff 30332!
This revision is now accepted and ready to land.Aug 28 2023, 8:25 AM
This revision now requires review to proceed.Aug 30 2023, 1:01 PM
ashoat added inline comments.
keyserver/src/socket/tunnelbroker.js
44

Can this be done in parallel instead of waiting for the await on line 42 to complete

This revision is now accepted and ready to land.Sep 6 2023, 6:13 PM
ashoat edited reviewers, added: jon; removed: ashoat.
ashoat foisted this revision upon kamil.
ashoat edited reviewers, added: ashoat; removed: kamil.

@kamil, would you mind taking over this diff, addressing my inline comment, and landing it?

@kamil, would you mind taking over this diff, addressing my inline comment, and landing it?

Sure, I'll address the comment before landing

  • address review
  • review before landing