Page MenuHomePhabricator
Differential D8996

[client-backup] implement API call to get UserData
ClosedPublic
Actions

Authored by kamil on Aug 29 2023, 2:21 AM.
Tags
None
Referenced Files
F6237405: D8996.diff
Thu, Apr 24, 4:33 PM
Unknown Object (File)
Wed, Apr 23, 3:19 AM
Unknown Object (File)
Sun, Apr 20, 7:11 AM
Unknown Object (File)
Sat, Apr 19, 12:30 PM
Unknown Object (File)
Sat, Apr 19, 11:05 AM
Unknown Object (File)
Fri, Apr 18, 10:09 PM
Unknown Object (File)
Fri, Apr 18, 10:40 AM
Unknown Object (File)
Fri, Apr 18, 9:07 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
marcin
bartek
Commits
rCOMMc29a59e1da0a: [client-backup] implement API call to get UserData
Summary

Call to get UserData associated with given BackupID.

Depends on D8995

Test Plan

Call this with mock data and verify result is correct.

Diff Detail

Repository
rCOMM Comm
Branch
land-client-backup
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Aug 29 2023, 2:21 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 29 2023, 2:21 AM
kamil added a child revision: D8997: [client-backup] extract code to handle HTTP error.Aug 29 2023, 2:31 AM
Harbormaster completed remote builds in B22199: Diff 30475.Aug 29 2023, 2:38 AM
kamil published this revision for review.Aug 29 2023, 3:19 AM
kamil added a reviewer: bartek.
michal accepted this revision.Aug 29 2023, 7:52 AM

LGTM, it's really similar to the previous diff, so I'm assuming any react native stuff will get solved there

This revision is now accepted and ready to land.Aug 29 2023, 7:52 AM
bartek accepted this revision.Aug 30 2023, 11:53 AM
kamil updated this revision to Diff 30671.Aug 31 2023, 1:21 PM

rebase

Harbormaster completed remote builds in B22327: Diff 30671.Aug 31 2023, 1:40 PM
Closed by commit rCOMMc29a59e1da0a: [client-backup] implement API call to get UserData (authored by kamil). · Explain WhyAug 31 2023, 1:53 PM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMc29a59e1da0a: [client-backup] implement API call to get UserData.

Revision Contents
Changeset List

PathSize
native/
backup/
28 lines

Diff 30671

View Options

native/backup/api.js

  • This file was added.
use cxx_build::CFG;
use glob::glob;
use std::fs;
use std::path::Path;
fn get_cpp_sources(path: &str) -> Vec<String> {
let mut sources: Vec<String> = Vec::<String>::new();
for entry in
glob(String::from(path.to_owned() + "/**/*.cpp").as_str()).unwrap()
{
jonUnsubmitted
Done
Inline Actions
let mut sources: Vec<String> = Vec::<String>::new();
- for entry in
- glob(String::from(path.to_owned() + "/**/*.cpp").as_str()).unwrap()
+ let files = glob(String::from(path.to_owned() + "/**/*.cpp").as_str())
+ .expect("Error gathering .cpp file paths");
+ for entry in files
+
{
sources.push(String::from(entry.unwrap().display().to_string()));

feel like this is a bit hard to read, and we should avoid explicit unwraps

jon: feel like this is a bit hard to read, and we should avoid explicit unwraps
maxAuthorUnsubmitted
Done
Inline Actions

feel like this is a bit hard to read, and we should avoid explicit unwraps

I don't mind changing it if you find it hard to read.
Changed.

max: > feel like this is a bit hard to read, and we should avoid explicit unwraps I don't mind…
sources.push(String::from(entry.unwrap().display().to_string()));
jonUnsubmitted
Done
Inline Actions
glob(String::from(path.to_owned() + "/**/*.cpp").as_str()).unwrap()
{
- sources.push(String::from(entry.unwrap().display().to_string()));
+ sources.push(entry.unwrap().display().to_string());
}
sources

String::from and .to_string() should be redundant

jon: `String::from` and `.to_string()` should be redundant
maxAuthorUnsubmitted
Done
Inline Actions

String::from and .to_string() should be redundant

Good catch, thanks!

max: > `String::from` and `.to_string()` should be redundant Good catch, thanks!
}
sources
}
fn add_import_path(import_path: &str) {
let shared_headers_import_path = fs::canonicalize(import_path).unwrap();
jonUnsubmitted
Done
Inline Actions

unwrap -> expect please.

jon: `unwrap` -> `expect` please.
CFG.exported_header_dirs.push(&shared_headers_import_path);
}
fn main() {
add_import_path("../lib/src");
add_import_path("src/libcpp/src");
add_import_path("src/libcpp/src/Amqp");
add_import_path("src/libcpp/src/Database");
add_import_path("src/libcpp/src/DeliveryBroker");
add_import_path("src/libcpp/src/Tools");
cxx_build::bridge("src/main.rs")
.files(get_cpp_sources("../lib/src"))
.files(get_cpp_sources("src/libcpp/src"))
.file(Path::new("src/libcpp/Tunnelbroker.cpp"))
.flag_if_supported("-std=c++17")
.flag_if_supported("-w")
.compile("tunnelbroker");
println!("cargo:rustc-link-lib=boost_program_options");
println!("cargo:rustc-link-lib=boost_system");
println!("cargo:rustc-link-lib=folly");
println!("cargo:rustc-link-lib=double-conversion");
println!("cargo:rustc-link-lib=gflags");
println!("cargo:rustc-link-lib=amqpcpp");
println!("cargo:rustc-link-lib=glog");
println!("cargo:rustc-link-lib=cryptopp");
println!("cargo:rustc-link-lib=ssl");
println!("cargo:rustc-link-lib=uv");
println!("cargo:rustc-link-lib=aws-cpp-sdk-core");
println!("cargo:rustc-link-lib=aws-cpp-sdk-dynamodb");
println!("cargo:rerun-if-changed=src/main.rs");
println!("cargo:rerun-if-changed=src/libcpp/Tunnelbroker.h");
println!("cargo:rerun-if-changed=src/libcpp/Tunnelbroker.cpp");
}