Paths

Table of Contentst

[client-backup] extract code to handle HTTP error
ClosedPublic
Actions

Authored by kamil on Aug 29 2023, 2:31 AM.

Details

Reviewers

michal
marcin
bartek

Commits

rCOMM386be857fbca: [client-backup] extract code to handle HTTP error

Summary

Reducing code duplication.

Depends on D8996

Test Plan

flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 29 2023, 2:31 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 29 2023, 2:31 AM

kamil added a child revision: D8998: [client-backup] add JS function to compute BackupKey based on user credentials.Aug 29 2023, 2:34 AM

Harbormaster completed remote builds in B22200: Diff 30476.Aug 29 2023, 2:47 AM

kamil published this revision for review.Aug 29 2023, 3:20 AM

Cool, this will simplify doing https://linear.app/comm/issue/ENG-3841/rethink-error-responses-for-blob-service in the future

This revision is now accepted and ready to land.Aug 29 2023, 5:43 AM

Closed by commit rCOMM386be857fbca: [client-backup] extract code to handle HTTP error (authored by kamil). · Explain WhyAug 31 2023, 1:53 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM386be857fbca: [client-backup] extract code to handle HTTP error.

Revision Contents
Changeset List

Path

Size

lib/

utils/

services-utils.js

10 lines

native/

backup/

api.js

21 lines

input/

input-state-container.react.js

6 lines

web/

input/

input-state-container.react.js

7 lines

Diff 30677

View Options

lib/utils/services-utils.js

View Options

native/backup/api.js

View Options

native/input/input-state-container.react.js

View Options

web/input/input-state-container.react.js

[client-backup] extract code to handle HTTP errorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30677

lib/utils/services-utils.js

native/backup/api.js

native/input/input-state-container.react.js

web/input/input-state-container.react.js

[client-backup] extract code to handle HTTP error
ClosedPublic
Actions

Revision Contents
Changeset List