Page MenuHomePhabricator
Differential D9010

[client-backup] add local settings to store
ClosedPublic
Actions

Authored by kamil on Aug 29 2023, 7:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 12:25 PM
Unknown Object (File)
Wed, Oct 23, 2:55 AM
Unknown Object (File)
Tue, Oct 22, 1:08 PM
Unknown Object (File)
Tue, Oct 22, 1:08 PM
Unknown Object (File)
Tue, Oct 22, 1:08 PM
Unknown Object (File)
Tue, Oct 22, 9:18 AM
Unknown Object (File)
Tue, Oct 22, 5:05 AM
Unknown Object (File)
Sat, Oct 19, 5:46 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
marcin
bartek
inka
Commits
rCOMM560da778d96e: [client-backup] add local settings to store
Summary

Allow user (for now only staff) to enable in disable automatic backup.

Toggle will be introduced in next diff.

Depends on D9003

Test Plan

Flip value and check result

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Aug 29 2023, 7:35 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 29 2023, 7:35 AM
kamil added a child revision: D9011: [client-backup] add backup menu screen.Aug 29 2023, 7:37 AM
kamil published this revision for review.Aug 29 2023, 7:50 AM
Harbormaster completed remote builds in B22223: Diff 30499.Aug 29 2023, 7:53 AM
kamil added a reviewer: inka.Aug 29 2023, 8:39 AM
inka accepted this revision.Aug 29 2023, 9:29 AM
inka added inline comments.
native/backup/backup-handler.js
33 ↗(On Diff #30499)

Can you please change this to || (!isStaff && !isDev)? This seems to be the preferred way in our codebase

This revision is now accepted and ready to land.Aug 29 2023, 9:29 AM
kamil updated this revision to Diff 30735.Sep 4 2023, 3:12 AM
  • improve condition
  • handle logout
kamil requested review of this revision.Sep 4 2023, 3:13 AM
Harbormaster completed remote builds in B22368: Diff 30735.Sep 4 2023, 3:29 AM
michal accepted this revision.Sep 4 2023, 8:34 AM
This revision is now accepted and ready to land.Sep 4 2023, 8:34 AM
Closed by commit rCOMM560da778d96e: [client-backup] add local settings to store (authored by kamil). · Explain WhySep 5 2023, 5:13 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM560da778d96e: [client-backup] add local settings to store.
kamil mentioned this in D9674: [native] fix handling logout action.Nov 2 2023, 2:46 AM
kamil mentioned this in rCOMM7bc50e51996e: [native] fix handling logout action.Nov 2 2023, 3:18 AM

Revision Contents
Changeset List

PathSize
native/
backup/
14 lines
redux/
5 lines
18 lines
2 lines
types/
5 lines

Diff 30735

View Options

native/backup/backup-handler.js

Loading...
View Options

native/redux/action-types.js

Loading...
View Options

native/redux/redux-setup.js

Loading...
View Options

native/redux/state-types.js

Loading...
View Options

native/types/local-settings-types.js

Loading...