Page MenuHomePhabricator

[native] Lift `onScroll` to `ConnectedChatThreadList`
ClosedPublic

Authored by atul on Sep 12 2023, 1:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 5:42 PM
Unknown Object (File)
Fri, Oct 25, 9:22 AM
Unknown Object (File)
Sat, Oct 19, 2:14 AM
Unknown Object (File)
Sat, Oct 19, 2:14 AM
Unknown Object (File)
Sat, Oct 19, 2:14 AM
Unknown Object (File)
Sat, Oct 19, 2:07 AM
Unknown Object (File)
Sun, Oct 13, 2:22 PM
Unknown Object (File)
Tue, Oct 8, 7:59 PM
Subscribers

Details

Summary

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.


Depends on D9136

Test Plan

ChatThreadList + search experience continue to work as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.Sep 12 2023, 2:07 PM

please see inline comment before landing

native/chat/chat-thread-list.react.js
129

I think this should be mixed

This revision is now accepted and ready to land.Sep 12 2023, 9:37 PM
native/chat/chat-thread-list.react.js
129

That's fair.

In a couple diffs though I completely remove these props after merging everything into a single component, so I think it's fine to leave as-is for now since this is temporary?