[native] Lift `renderItem` to `ConnectedChatThreadList`
ClosedPublic
Actions

Authored by atul on Sep 12 2023, 4:57 PM.

Details

Reviewers

ginsu
tomek
rohan

Commits

rCOMMae6086fcf3f9: [native] Lift `renderItem` to `ConnectedChatThreadList`

Summary

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.

Depends on D9172

Test Plan

ChatThreadList + search experience continue to work as expected.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Sep 12 2023, 4:57 PM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 12 2023, 4:57 PM

atul published this revision for review.Sep 12 2023, 5:10 PM

Harbormaster completed remote builds in B22568: Diff 31018.Sep 12 2023, 5:15 PM

atul added a child revision: D9174: [native] Replace `listDataSelector` with `useMemo` in `ChatThreadList`.Sep 13 2023, 8:02 AM

ginsu accepted this revision.Sep 13 2023, 9:41 AM

This revision is now accepted and ready to land.Sep 13 2023, 9:41 AM

rebase and land

This revision was landed with ongoing or failed builds.Sep 13 2023, 11:30 AM

Closed by commit rCOMMae6086fcf3f9: [native] Lift `renderItem` to `ConnectedChatThreadList` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMae6086fcf3f9: [native] Lift `renderItem` to `ConnectedChatThreadList`.

Harbormaster completed remote builds in B22610: Diff 31085.Sep 13 2023, 11:46 AM

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-thread-list.react.js

62 lines

Diff 31018

View Options

native/chat/chat-thread-list.react.js

	Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
	-DSQLITE_ENABLE_FTS3_PARENTHESIS			-DSQLITE_ENABLE_FTS3_PARENTHESIS
	-DSQLITE_THREADSAFE=0			-DSQLITE_THREADSAFE=0
	-DSQLITE_ENABLE_NORMALIZE			-DSQLITE_ENABLE_NORMALIZE
	-DSQLITE_HAS_CODEC			-DSQLITE_HAS_CODEC
	-DSQLITE_TEMP_STORE=2			-DSQLITE_TEMP_STORE=2
	-DSQLCIPHER_CRYPTO_OPENSSL			-DSQLCIPHER_CRYPTO_OPENSSL
	-DSQLITE_ENABLE_SESSION			-DSQLITE_ENABLE_SESSION
	-DSQLITE_ENABLE_PREUPDATE_HOOK			-DSQLITE_ENABLE_PREUPDATE_HOOK
				-DSQLITE_ENABLE_FTS5
	)			)

	download_openssl() {			download_openssl() {
	mkdir -p "$SQLITE_DIR"			mkdir -p "$SQLITE_DIR"

	curl "${OPENSSL_URL}" --output "${OPENSSL_FILE}"			curl "${OPENSSL_URL}" --output "${OPENSSL_FILE}"

	tar -xf "${OPENSSL_FILE}" -C "${SQLITE_DIR}"			tar -xf "${OPENSSL_FILE}" -C "${SQLITE_DIR}"
	▲ Show 20 Lines • Show All 112 Lines • Show Last 20 Lines

[native] Lift `renderItem` to `ConnectedChatThreadList`ClosedPublicActions