[native] utilize memoization in the MesssageHeader component
ClosedPublic
Actions

Authored by ginsu on Oct 6 2023, 3:54 AM.

Details

Reviewers

atul
inka

Commits

rCOMMa7a07970d92a: [native] utilize memoization in the MesssageHeader component

Summary

I plan to make the user profiles accessible from the message author username in the MessageHeader. However, I noticed that MessageHeader could be better memoized. I figured it would be helpful to quickly improve the memoization here before I make this an access point for the user profile bottom sheet

Depends on D9289

Test Plan

confirmed that MessageHeader still works and looks the same

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 6 2023, 3:54 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 6 2023, 3:54 AM

ginsu edited the summary of this revision. (Show Details)Oct 6 2023, 3:56 AM

ginsu added reviewers: atul, inka.

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D9289: [native] make user profile accessible from message author avatar.

ginsu added a child revision: D9386: [native] make user profile accessible from message author name.Oct 6 2023, 4:02 AM

Harbormaster completed remote builds in B23043: Diff 31732.Oct 6 2023, 4:11 AM

ginsu requested review of this revision.Oct 6 2023, 4:11 AM

atul accepted this revision.Oct 9 2023, 12:41 PM

This revision is now accepted and ready to land.Oct 9 2023, 12:41 PM

rebase before landing

Harbormaster completed remote builds in B23159: Diff 31890.Oct 11 2023, 1:49 AM

Closed by commit rCOMMa7a07970d92a: [native] utilize memoization in the MesssageHeader component (authored by ginsu). · Explain WhyOct 11 2023, 2:39 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMa7a07970d92a: [native] utilize memoization in the MesssageHeader component.

Revision Contents
Changeset List

Path

Size

native/

chat/

message-header.react.js

52 lines

Diff 31890

View Options

native/chat/message-header.react.js

	Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines

	export type FFmpegStatistics = {			export type FFmpegStatistics = {
	// seconds of video being processed per second			// seconds of video being processed per second
	+speed: number,			+speed: number,
	// total milliseconds of video processed so far			// total milliseconds of video processed so far
	+time: number,			+time: number,
	// total result file size in bytes so far			// total result file size in bytes so far
	+size: number,			+size: number,
	+videoQuality: number,
	+videoFrameNumber: number,
	+videoFps: number,
	+bitrate: number,
	};			};

	export type TranscodeVideoMediaMissionStep = {			export type TranscodeVideoMediaMissionStep = {
	+step: 'video_ffmpeg_transcode',			+step: 'video_ffmpeg_transcode',
	+success: boolean,			+success: boolean,
	+exceptionMessage: ?string,			+exceptionMessage: ?string,
	+time: number, // ms			+time: number, // ms
	+returnCode: ?number,
	+newPath: ?string,			+newPath: ?string,
	+stats: ?FFmpegStatistics,			+stats: ?FFmpegStatistics,
	};			};

	export type VideoGenerateThumbnailMediaMissionStep = {			export type VideoGenerateThumbnailMediaMissionStep = {
	+step: 'video_generate_thumbnail',			+step: 'video_generate_thumbnail',
	+success: boolean,			+success: boolean,
	+time: number, // ms			+time: number, // ms
	▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines

[native] utilize memoization in the MesssageHeader componentClosedPublicActions