Page MenuHomePhabricator
Differential D9387

[native] simplify ThreadSettingsMember jsx
ClosedPublic
Actions

Authored by ginsu on Oct 6 2023, 4:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 7:20 AM
Unknown Object (File)
Wed, Apr 2, 7:57 PM
Unknown Object (File)
Sun, Mar 16, 9:32 PM
Unknown Object (File)
Mar 13 2025, 4:51 PM
Unknown Object (File)
Mar 13 2025, 4:51 PM
Unknown Object (File)
Mar 13 2025, 4:51 PM
Unknown Object (File)
Mar 13 2025, 4:51 PM
Unknown Object (File)
Mar 13 2025, 4:45 PM
View All 100 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMM5e7c7a9ee84c: [native] simplify ThreadSettingsMember jsx
Summary

Small refactor diff to simplify the JSX being returned in ThreadSettingsMember before I made this into a touchable

Depends on D9386

Test Plan

Confrimed that ThreadSettingsMember still looks and behaves the same

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 6 2023, 4:04 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 6 2023, 4:04 AM
ginsu edited the summary of this revision. (Show Details)Oct 6 2023, 4:05 AM
ginsu added a parent revision: D9386: [native] make user profile accessible from message author name.
ginsu added reviewers: atul, inka.Oct 6 2023, 4:07 AM
ginsu added a child revision: D9388: [native] make user profile accessible from ThreadSettingsMember.Oct 6 2023, 4:12 AM
Harbormaster completed remote builds in B23045: Diff 31734.Oct 6 2023, 4:20 AM
ginsu requested review of this revision.Oct 6 2023, 4:20 AM
atul accepted this revision.Oct 6 2023, 1:28 PM
This revision is now accepted and ready to land.Oct 6 2023, 1:28 PM
ginsu updated this revision to Diff 31892.Oct 11 2023, 1:33 AM

rebase before landing

Harbormaster completed remote builds in B23161: Diff 31892.Oct 11 2023, 1:51 AM
Closed by commit rCOMM5e7c7a9ee84c: [native] simplify ThreadSettingsMember jsx (authored by ginsu). · Explain WhyOct 11 2023, 2:39 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM5e7c7a9ee84c: [native] simplify ThreadSettingsMember jsx.

Revision Contents
Changeset List

PathSize
native/
chat/
settings/
36 lines

Diff 31892

View Options

native/chat/settings/thread-settings-member.react.js

Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Lines
} }
div.main-header > h1 { div.main-header > h1 {
color: var(--fg); color: var(--fg);
padding-left: 92px; padding-left: 92px;
font-family: var(--font-logo); font-family: var(--font-logo);
line-height: var(--line-height-text); line-height: var(--line-height-text);
font-weight: var(--semi-bold); font-weight: var(--semi-bold);
font-size: var(--logo-font-22); font-size: var(--logo-font-22);
cursor: pointer;
} }
div.main-content-container { div.main-content-container {
position: relative; position: relative;
grid-area: app; grid-area: app;
} }
div.main-content { div.main-content {
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 189 Lines • Show Last 20 Lines