[native] simplify ThreadSettingsMember jsx
ClosedPublic
Actions

Authored by ginsu on Oct 6 2023, 4:04 AM.

Details

Reviewers

atul
inka

Commits

rCOMM5e7c7a9ee84c: [native] simplify ThreadSettingsMember jsx

Summary

Small refactor diff to simplify the JSX being returned in ThreadSettingsMember before I made this into a touchable

Depends on D9386

Test Plan

Confrimed that ThreadSettingsMember still looks and behaves the same

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 6 2023, 4:04 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 6 2023, 4:04 AM

ginsu edited the summary of this revision. (Show Details)Oct 6 2023, 4:05 AM

ginsu added a parent revision: D9386: [native] make user profile accessible from message author name.

ginsu added reviewers: atul, inka.Oct 6 2023, 4:07 AM

ginsu added a child revision: D9388: [native] make user profile accessible from ThreadSettingsMember.Oct 6 2023, 4:12 AM

Harbormaster completed remote builds in B23045: Diff 31734.Oct 6 2023, 4:20 AM

ginsu requested review of this revision.Oct 6 2023, 4:20 AM

atul accepted this revision.Oct 6 2023, 1:28 PM

This revision is now accepted and ready to land.Oct 6 2023, 1:28 PM

rebase before landing

Harbormaster completed remote builds in B23161: Diff 31892.Oct 11 2023, 1:51 AM

Closed by commit rCOMM5e7c7a9ee84c: [native] simplify ThreadSettingsMember jsx (authored by ginsu). · Explain WhyOct 11 2023, 2:39 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM5e7c7a9ee84c: [native] simplify ThreadSettingsMember jsx.

Revision Contents
Changeset List

Path

Size

native/

chat/

settings/

thread-settings-member.react.js

36 lines

Diff 31892

View Options

native/chat/settings/thread-settings-member.react.js

[native] simplify ThreadSettingsMember jsxClosedPublicActions