issue: https://linear.app/comm/issue/ENG-4681/create-action-objects-for-all-actions
also removed accountPassword argument, that was deprecated by this stack: https://phab.comm.dev/D6103
Adding @marcin to review, since it was their stack
Details
Details
Tested that the actions work as expected
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/src/responders/thread-responders.js | ||
|---|---|---|
| 69 ↗ | (On Diff #31686) | If I remember correctly this will stop accepting requests from older clients (because they will still send accountPassword). We should probably leave the validator as it is and change the ThreadDeletionRequest.accountPassword to (optional) empty so flow complains if you try and do anything with it. |
| lib/actions/thread-actions.js | ||
| 44 ↗ | (On Diff #31686) | We shouldn't hide await inside of an another expression |