Page MenuHomePhabricator
Differential D10917

[web] update `getClientStore` name
ClosedPublic
Actions

Authored by kamil on Feb 1 2024, 12:43 PM.
Tags
None
Referenced Files
F3280350: D10917.id36550.diff
Sat, Nov 16, 9:07 AM
F3276048: D10917.diff
Sat, Nov 16, 7:19 AM
Unknown Object (File)
Wed, Nov 6, 4:09 PM
Unknown Object (File)
Oct 15 2024, 7:04 AM
Unknown Object (File)
Oct 15 2024, 7:04 AM
Unknown Object (File)
Oct 15 2024, 7:04 AM
Unknown Object (File)
Oct 15 2024, 7:04 AM
Unknown Object (File)
Oct 15 2024, 7:04 AM
View All 56 Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
michal
tomek
Commits
rCOMMe4972363514f: [web] update `getClientStore` name
Summary

Follow-up to https://phab.comm.dev/D10780#inline-65805.

Depends on D10780

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
ks-sql-3
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Feb 1 2024, 12:43 PM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 1 2024, 12:43 PM
kamil published this revision for review.Feb 1 2024, 12:44 PM
kamil edited reviewers, added: marcin, michal, tomek; removed: will, varun, bartek.
kamil added inline comments.
web/database/utils/store.js
14

rename to match native (we have the same function in CommCoreModule)

web/database/worker/process-operations.js
164

not sure if it's the best name but can't think of anything better

kamil mentioned this in D10780: [SQLite] implement C++ code to get keyservers.Feb 1 2024, 12:45 PM
Harbormaster completed remote builds in B26435: Diff 36550.Feb 1 2024, 1:02 PM
kamil added a child revision: D10781: [SQLite] implement processing keyserver store ops on worker.Feb 2 2024, 3:13 AM
marcin accepted this revision.Feb 5 2024, 2:05 AM
This revision is now accepted and ready to land.Feb 5 2024, 2:05 AM
kamil updated this revision to Diff 36634.Feb 5 2024, 11:06 AM

rebase

This revision was landed with ongoing or failed builds.Feb 5 2024, 11:23 AM
Closed by commit rCOMMe4972363514f: [web] update `getClientStore` name (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMe4972363514f: [web] update `getClientStore` name.
Harbormaster completed remote builds in B26502: Diff 36634.Feb 5 2024, 11:24 AM

Revision Contents
Changeset List

PathSize
web/
database/
utils/
4 lines
worker/
4 lines
4 lines
redux/
4 lines

Diff 36550

View Options

web/database/utils/store.js

Loading...
View Options

web/database/worker/db-worker.js

Loading...
View Options

web/database/worker/process-operations.js

Loading...
View Options

web/redux/initial-state-gate.js

Loading...