Page MenuHomePhabricator

[keyserver] Create invite link blobs in a migration
ClosedPublic

Authored by tomek on Feb 14 2024, 7:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 26, 6:23 AM
Unknown Object (File)
Sat, Jan 25, 2:15 AM
Unknown Object (File)
Sat, Jan 25, 2:15 AM
Unknown Object (File)
Sat, Jan 25, 2:15 AM
Unknown Object (File)
Thu, Jan 23, 10:33 PM
Unknown Object (File)
Tue, Jan 21, 12:38 PM
Unknown Object (File)
Dec 26 2024, 11:36 AM
Unknown Object (File)
Dec 26 2024, 11:36 AM
Subscribers

Details

Summary

In D10206 we're running this in cron, but we also should do that in a migration - this isn't strictly necessary because cron would update it later, but it is better to do that immediately.

Additionally, the function was modified so that the migration / job doesn't fail in environments where we aren't authenticated to Identity service.

Depends on D11051

Test Plan

Run the keyserver and check if the migration creates holders in invite_links table.
Kill the keyserver, delete auth metadata, decrement db version, delete the holder and update invite link secret. Then run the keyserver - the migration should succeed by printing an error message - the holder shouldn't be created.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Feb 14 2024, 7:21 AM
This revision is now accepted and ready to land.Feb 14 2024, 7:46 AM
keyserver/src/utils/synchronizeInviteLinksWithBlobs.js
44

Will monitor for this string next time I deploy the keyserver