Page MenuHomePhabricator
Differential D11413

[identity] on linkFarcasterUser we should return an error if the FID already exists for a different user in the users table
ClosedPublic
Actions

Authored by varun on Mar 27 2024, 1:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 11:26 AM
Unknown Object (File)
Sun, Mar 30, 2:05 PM
Unknown Object (File)
Sun, Mar 30, 8:00 AM
Unknown Object (File)
Sun, Mar 30, 6:52 AM
Unknown Object (File)
Sat, Mar 29, 4:00 PM
Unknown Object (File)
Wed, Mar 26, 7:37 AM
Unknown Object (File)
Feb 18 2025, 7:06 PM
Unknown Object (File)
Feb 18 2025, 7:06 PM
View All 71 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMM7e269eae587e: [identity] on linkFarcasterUser we should return an error if the FID already…
Summary

LinkFarcasterUser should succeed if the FID is already associated with this user (no-op) but should fail if the FID is already associated with another user. We don't want the same FID associated with multiple Comm users.

Depends on D11412

Test Plan

Tried calling the RPC with an FID already associated with a different user and it failed. Tried calling with an FID associated with this user and it succeeded. Tried calling with an FID associated with no users and it succeeded.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
identity/
src/
grpc_services/
21 lines

Diff 38391

View Options

services/identity/src/grpc_services/authenticated.rs

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { useDispatch } from 'react-redux'; import { useDispatch } from 'react-redux';
import { logOut, logOutActionTypes } from 'lib/actions/user-actions.js'; import { logOut, logOutActionTypes } from 'lib/actions/user-actions.js';
import { preRequestUserStateSelector } from 'lib/selectors/account-selectors.js'; import { preRequestUserStateSelector } from 'lib/selectors/account-selectors.js';
import { import {
cookieSelector, cookieSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector, lastCommunicatedPlatformDetailsSelector,
} from 'lib/selectors/keyserver-selectors.js'; } from 'lib/selectors/keyserver-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { accountHasPassword } from 'lib/shared/account-utils.js'; import { accountHasPassword } from 'lib/shared/account-utils.js';
import { useInitialNotificationsEncryptedMessage } from 'lib/shared/crypto-utils.js';
import Socket, { type BaseSocketProps } from 'lib/socket/socket.react.js'; import Socket, { type BaseSocketProps } from 'lib/socket/socket.react.js';
import { logInActionSources } from 'lib/types/account-types.js'; import { logInActionSources } from 'lib/types/account-types.js';
import { import {
useServerCall, useServerCall,
useDispatchActionPromise, useDispatchActionPromise,
fetchNewCookieFromNativeCredentials, fetchNewCookieFromNativeCredentials,
} from 'lib/utils/action-utils.js'; } from 'lib/utils/action-utils.js';
import { InputStateContext } from './input/input-state.js'; import { InputStateContext } from './input/input-state.js';
import { import {
activeMessageListSelector, activeMessageListSelector,
nativeCalendarQuery, nativeCalendarQuery,
} from './navigation/nav-selectors.js'; } from './navigation/nav-selectors.js';
import { NavContext } from './navigation/navigation-context.js'; import { NavContext } from './navigation/navigation-context.js';
import { useSelector } from './redux/redux-utils.js'; import { useSelector } from './redux/redux-utils.js';
import { noDataAfterPolicyAcknowledgmentSelector } from './selectors/account-selectors.js'; import { noDataAfterPolicyAcknowledgmentSelector } from './selectors/account-selectors.js';
import { import {
openSocketSelector, openSocketSelector,
sessionIdentificationSelector, sessionIdentificationSelector,
nativeGetClientResponsesSelector, nativeGetClientResponsesSelector,
nativeSessionStateFuncSelector, nativeSessionStateFuncSelector,
} from './selectors/socket-selectors.js'; } from './selectors/socket-selectors.js';
import Alert from './utils/alert.js'; import Alert from './utils/alert.js';
import { useInitialNotificationsEncryptedMessage } from './utils/crypto-utils.js'; import { nativeNotificationsSessionCreator } from './utils/crypto-utils.js';
import { decompressMessage } from './utils/decompress.js'; import { decompressMessage } from './utils/decompress.js';
const NativeSocket: React.ComponentType<BaseSocketProps> = const NativeSocket: React.ComponentType<BaseSocketProps> =
React.memo<BaseSocketProps>(function NativeSocket(props: BaseSocketProps) { React.memo<BaseSocketProps>(function NativeSocket(props: BaseSocketProps) {
const inputState = React.useContext(InputStateContext); const inputState = React.useContext(InputStateContext);
const navContext = React.useContext(NavContext); const navContext = React.useContext(NavContext);
const cookie = useSelector(cookieSelector); const cookie = useSelector(cookieSelector);
Show All 11 Lines React.memo<BaseSocketProps>(function NativeSocket(props: BaseSocketProps) {
const currentUserInfo = useSelector(state => state.currentUserInfo); const currentUserInfo = useSelector(state => state.currentUserInfo);
const openSocket = useSelector(openSocketSelector); const openSocket = useSelector(openSocketSelector);
invariant(openSocket, 'openSocket failed to be created'); invariant(openSocket, 'openSocket failed to be created');
const sessionIdentification = useSelector(sessionIdentificationSelector); const sessionIdentification = useSelector(sessionIdentificationSelector);
const preRequestUserState = useSelector(preRequestUserStateSelector); const preRequestUserState = useSelector(preRequestUserStateSelector);
const getInitialNotificationsEncryptedMessage = const getInitialNotificationsEncryptedMessage =
useInitialNotificationsEncryptedMessage(); useInitialNotificationsEncryptedMessage(
nativeNotificationsSessionCreator,
);
const getClientResponses = useSelector(state => const getClientResponses = useSelector(state =>
nativeGetClientResponsesSelector({ nativeGetClientResponsesSelector({
redux: state, redux: state,
navContext, navContext,
getInitialNotificationsEncryptedMessage, getInitialNotificationsEncryptedMessage,
}), }),
); );
▲ Show 20 Lines • Show All 98 Lines • Show Last 20 Lines