Paths

Table of Contentst

-
keyserver/src/fetchers/
-
src/
-
fetchers/
-
thread-fetchers.js

Differential D11204

[web][native][keyserver] Flip the switch to enable `specialRole` field
ClosedPublic
Actions

Authored by atul on Mar 1 2024, 10:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 22, 8:57 AM

	Unknown Object (File)
	Tue, Mar 18, 7:05 AM

	Unknown Object (File)
	Fri, Mar 14, 4:57 AM

	Unknown Object (File)
	Fri, Mar 14, 4:48 AM

	Unknown Object (File)
	Fri, Mar 14, 4:43 AM

	Unknown Object (File)
	Wed, Mar 12, 5:01 PM

	Unknown Object (File)
	Fri, Mar 7, 7:33 AM

	Unknown Object (File)
	Mon, Mar 3, 3:15 PM

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMMbbac2afa8f62: [web][native][keyserver] Flip the switch to enable `specialRole` field
rCOMMddd4c2b39b04: [web][native][keyserver] Flip the switch to enable `specialRole` field

Summary

This diff will need to be landed at the same time as a release/codeVersion bump so things don't break in developer's local environment.

Will send message in Releases channel when ready.

Depends on D11188

Test Plan

Have a local "do not land" diff that does this locally and things work as expected.

Diff Detail

Repository

Branch

arcpatch-D11204 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 1 2024, 10:43 AM

Harbormaster completed remote builds in B27251: Diff 37728.Mar 1 2024, 11:06 AM

atul requested review of this revision.Mar 1 2024, 11:06 AM

atul edited the summary of this revision. (Show Details)Mar 1 2024, 11:42 AM

atul added a parent revision: D11188: [web] Redux migration to patch in `specialRole` field.

atul added a child revision: D11205: [lib][native] Introduce `useRoleNamesToSpecialRole` to remove `"Admins"` string check in `RolePanelEntry`.Mar 1 2024, 12:03 PM

ashoat added inline comments.Mar 1 2024, 1:32 PM

keyserver/src/fetchers/thread-fetchers.js
291 ↗	(On Diff #37728)	Should this variable be renamed?

Just going to accept this to move it off my queue, but in our 1:1 @atul mentioned he still wanted to do some additional testing before landing

This revision is now accepted and ready to land.Mar 1 2024, 3:14 PM

amend

atul added inline comments.Apr 22 2024, 11:26 AM

keyserver/src/fetchers/thread-fetchers.js
289–290 ↗	(On Diff #39352)	Bumping these in D11188 and D11099 which will be landed immediately after `keyserver` release. Can change to `NEXT_CODE_VERSION`, but want to make clear that we don't actually need mobile releases... just need to bump the values.

Harbormaster completed remote builds in B28362: Diff 39352.Apr 22 2024, 11:35 AM

land

This revision was landed with ongoing or failed builds.Apr 22 2024, 12:12 PM

Closed by commit rCOMMddd4c2b39b04: [web][native][keyserver] Flip the switch to enable `specialRole` field (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMddd4c2b39b04: [web][native][keyserver] Flip the switch to enable `specialRole` field.

atul added a reverting change: rCOMM560e48ea3541: Revert "[web][native][keyserver] Flip the switch to enable `specialRole` field".Apr 22 2024, 12:26 PM

Harbormaster completed remote builds in B28368: Diff 39358.Apr 22 2024, 12:33 PM

atul reopened this revision.Apr 22 2024, 1:31 PM

This revision is now accepted and ready to land.Apr 22 2024, 1:31 PM

amend

change web minCodeVersion to NEXT_CODE_VERSION

This revision was landed with ongoing or failed builds.Apr 22 2024, 6:34 PM

Closed by commit rCOMMbbac2afa8f62: [web][native][keyserver] Flip the switch to enable `specialRole` field (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMbbac2afa8f62: [web][native][keyserver] Flip the switch to enable `specialRole` field.

Harbormaster completed remote builds in B28390: Diff 39384.Apr 22 2024, 6:40 PM

Harbormaster completed remote builds in B28391: Diff 39385.Apr 22 2024, 6:45 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

thread-fetchers.js

14 lines

Diff 39358

keyserver/src/fetchers/thread-fetchers.js

	Show All 40 Lines		function ManagePublicLinkScreen(props: Props): React.Node {
	let errorComponent = null;			let errorComponent = null;
	if (error) {			if (error) {
	errorComponent = <Text style={styles.error}>{error}</Text>;			errorComponent = <Text style={styles.error}>{error}</Text>;
	}			}

	const onDisableButtonClick = React.useCallback(() => {			const onDisableButtonClick = React.useCallback(() => {
	Alert.alert(			Alert.alert(
	'Disable public link',			'Disable public link',
	'Are you sure you want to disable your public link? Members who have your community’s public link but have not joined will not able to with the disabled link. \n' +			'Are you sure you want to disable your public link?\n' +
	'\n' +			'\n' +
	'Other communities may also claim your previous public link url.',			'Other communities will be able to claim the same URL.',
	[			[
	{			{
	text: 'Confirm disable',			text: 'Confirm disable',
	style: 'destructive',			style: 'destructive',
	onPress: disableInviteLink,			onPress: disableInviteLink,
	},			},
	{			{
	text: 'Cancel',			text: 'Cancel',
	Show All 18 Lines		disablePublicLinkButton = (
	</View>			</View>
	);			);
	}			}

	return (			return (
	<View>			<View>
	<View style={styles.section}>			<View style={styles.section}>
	<Text style={styles.sectionText}>			<Text style={styles.sectionText}>
	Let your community be more accessible with your own unique public			Invite links make it easy for your friends to join your community.
	link. By enabling a public link, you are allowing anyone who has your			Anybody who knows your community’s invite link will be able to join
	link to join your community.{'\n\n'}			it. Note that if you change your public link’s URL, other communities
	Editing your community’s public link allows other communities to claim			will be able to claim the old URL.
				ashoatUnsubmitted Not Done Inline Actions From the screenshot, this looks like too much text in a row. We could try separating out the third sentence into its own paragraph. We could also try showing the three sentences as three bullet points. @ted, any thoughts? ashoat: From the screenshot, this looks like too much text in a row. We could try separating out the…
				tomekAuthorUnsubmitted Done Inline Actions In the original design, the last sentence was separated by an empty line. It probably makes sense to do the same here. tomek: In the original design, the last sentence was separated by an empty line. It probably makes…
	your previous URL.
	</Text>			</Text>
	</View>			</View>
	<Text style={styles.sectionTitle}>INVITE URL</Text>			<Text style={styles.sectionTitle}>INVITE URL</Text>
	<View style={styles.section}>			<View style={styles.section}>
	<View style={styles.inviteLink}>			<View style={styles.inviteLink}>
	<Text style={styles.inviteLinkPrefix}>{inviteLinkUrl('')}</Text>			<Text style={styles.inviteLinkPrefix}>{inviteLinkUrl('')}</Text>
	<TextInput			<TextInput
	style={styles.input}			style={styles.input}
	▲ Show 20 Lines • Show All 108 Lines • Show Last 20 Lines