[lib][native][web] Rename useLogIn to useLegacyLogIn
ClosedPublic
Actions

Authored by ashoat on Apr 24 2024, 12:41 PM.

Details

Reviewers

tomek
inka

Commits

rCOMM60e5ad1f8f90: [lib][native][web] Rename useLogIn to useLegacyLogIn

Summary

This diffs also renames several related constants and utilities. This reflects the fact that these login methods are deprecated in favor of the new identity-based login flows.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 24 2024, 12:41 PM

Harbormaster completed remote builds in B28440: Diff 39450.Apr 24 2024, 1:01 PM

ashoat requested review of this revision.Apr 24 2024, 1:01 PM

Should we rename siweAuthActionTypes to legacySiweAuthActionTypes and keyserverRegisterActionTypes to legacyKeyserverRegisterActionTypes?

This revision is now accepted and ready to land.Apr 26 2024, 6:57 AM

In D11764#338319, @inka wrote:

Should we rename siweAuthActionTypes to legacySiweAuthActionTypes and keyserverRegisterActionTypes to legacyKeyserverRegisterActionTypes?

Good call. I'll do those in separate diffs

Closed by commit rCOMM60e5ad1f8f90: [lib][native][web] Rename useLogIn to useLegacyLogIn (authored by ashoat). · Explain WhyApr 26 2024, 8:18 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM60e5ad1f8f90: [lib][native][web] Rename useLogIn to useLegacyLogIn.

ashoat mentioned this in D11802: [lib][native][web] Rename siweAuth to legacySiweAuth.Apr 26 2024, 11:25 AM

ashoat mentioned this in D11803: [lib][native] Rename keyserverRegister to legacyKeyserverRegister.

ashoat mentioned this in D11805: [lib][native][web] Rename some legacy login types.Apr 26 2024, 11:27 AM

ashoat mentioned this in D11806: [lib][native][web] Rename LogInExtraInfo to LegacyLogInExtraInfo.

In D11764#338363, @ashoat wrote:

In D11764#338319, @inka wrote:

Should we rename siweAuthActionTypes to legacySiweAuthActionTypes and keyserverRegisterActionTypes to legacyKeyserverRegisterActionTypes?

Good call. I'll do those in separate diffs