Page MenuHomePhabricator
Differential D12373

[lib] factor out broadcasting device list updates to hook
ClosedPublic
Actions

Authored by kamil on Jun 10 2024, 4:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 6:48 AM
Unknown Object (File)
Mon, Mar 3, 6:48 AM
Unknown Object (File)
Fri, Feb 28, 2:09 AM
Unknown Object (File)
Feb 15 2025, 8:27 PM
Unknown Object (File)
Feb 6 2025, 11:45 AM
Unknown Object (File)
Feb 6 2025, 11:45 AM
Unknown Object (File)
Jan 24 2025, 9:33 PM
Unknown Object (File)
Jan 24 2025, 9:33 PM
View All 65 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMMb1a04e641028: [lib] factor out broadcasting device list updates to hook
Summary

We want to reuse this code in more places, whenever disseminating device list updates.

Depends on D12347

Test Plan

Hook tested by calling function.
Secondary device auth not tested because of: ENG-8385.

Diff Detail

Repository
rCOMM Comm
Branch
peer-list-3
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jun 10 2024, 4:25 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJun 10 2024, 4:25 AM
kamil added a child revision: D12374: [lib] factor out getting and updating device list to hook.Jun 10 2024, 4:32 AM
Harbormaster completed remote builds in B29566: Diff 41153.Jun 10 2024, 4:40 AM
kamil edited the summary of this revision. (Show Details)Jun 10 2024, 9:41 AM
kamil published this revision for review.Jun 10 2024, 9:50 AM
tomek accepted this revision.Jun 12 2024, 5:43 AM
This revision is now accepted and ready to land.Jun 12 2024, 5:43 AM
bartek added inline comments.Jun 12 2024, 8:44 AM
native/profile/secondary-device-qr-code-scanner.react.js
107–112

We have fetchLatestDeviceList() in lib/shared/device-list-utils.js that does exactly this

kamil added inline comments.Jun 13 2024, 7:54 AM
native/profile/secondary-device-qr-code-scanner.react.js
107–112

yeah but in this case we also need lastSignedDeviceList

Closed by commit rCOMMb1a04e641028: [lib] factor out broadcasting device list updates to hook (authored by kamil). · Explain WhyJun 13 2024, 9:08 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMb1a04e641028: [lib] factor out broadcasting device list updates to hook.

Revision Contents
Changeset List

PathSize
lib/
hooks/
50 lines
native/
profile/
50 lines

Diff 41153

View Options

lib/hooks/peer-list-hooks.js

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines
} from '../types/message-types.js'; } from '../types/message-types.js';
import type { import type {
MinimallyEncodedRawThreadInfo, MinimallyEncodedRawThreadInfo,
MinimallyEncodedThreadCurrentUserInfo, MinimallyEncodedThreadCurrentUserInfo,
MinimallyEncodedThreadInfo, MinimallyEncodedThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import { import {
decodeMinimallyEncodedRoleInfo, decodeMinimallyEncodedRoleInfo,
minimallyEncodeRawThreadInfo,
minimallyEncodeThreadInfo, minimallyEncodeThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { import {
threadPermissionPropagationPrefixes, threadPermissionPropagationPrefixes,
threadPermissions, threadPermissions,
configurableCommunityPermissions, configurableCommunityPermissions,
type ThreadPermission, type ThreadPermission,
▲ Show 20 Lines • Show All 655 Lines • ▼ Show 20 Linesasync function createRealThreadFromPendingThread({
return newThreadID; return newThreadID;
} }
type RawThreadInfoOptions = { type RawThreadInfoOptions = {
+filterThreadEditAvatarPermission?: boolean, +filterThreadEditAvatarPermission?: boolean,
+excludePinInfo?: boolean, +excludePinInfo?: boolean,
+filterManageInviteLinksPermission?: boolean, +filterManageInviteLinksPermission?: boolean,
+filterVoicedInAnnouncementChannelsPermission?: boolean, +filterVoicedInAnnouncementChannelsPermission?: boolean,
+minimallyEncodePermissions?: boolean,
}; };
function rawThreadInfoFromServerThreadInfo( function rawThreadInfoFromServerThreadInfo(
serverThreadInfo: ServerThreadInfo, serverThreadInfo: ServerThreadInfo,
viewerID: string, viewerID: string,
options?: RawThreadInfoOptions, options?: RawThreadInfoOptions,
): ?LegacyRawThreadInfo { ): ?RawThreadInfo {
const filterThreadEditAvatarPermission = const filterThreadEditAvatarPermission =
options?.filterThreadEditAvatarPermission; options?.filterThreadEditAvatarPermission;
const excludePinInfo = options?.excludePinInfo; const excludePinInfo = options?.excludePinInfo;
const filterManageInviteLinksPermission = const filterManageInviteLinksPermission =
options?.filterManageInviteLinksPermission; options?.filterManageInviteLinksPermission;
const filterVoicedInAnnouncementChannelsPermission = const filterVoicedInAnnouncementChannelsPermission =
options?.filterVoicedInAnnouncementChannelsPermission; options?.filterVoicedInAnnouncementChannelsPermission;
const shouldMinimallyEncodePermissions = options?.minimallyEncodePermissions;
const filterThreadPermissions = _omitBy( const filterThreadPermissions = _omitBy(
(v, k) => (v, k) =>
(filterThreadEditAvatarPermission && (filterThreadEditAvatarPermission &&
[ [
threadPermissions.EDIT_THREAD_AVATAR, threadPermissions.EDIT_THREAD_AVATAR,
threadPermissionPropagationPrefixes.DESCENDANT + threadPermissionPropagationPrefixes.DESCENDANT +
threadPermissions.EDIT_THREAD_AVATAR, threadPermissions.EDIT_THREAD_AVATAR,
▲ Show 20 Lines • Show All 88 Lines • ▼ Show 20 Lines): ?RawThreadInfo {
const sourceMessageID = serverThreadInfo.sourceMessageID; const sourceMessageID = serverThreadInfo.sourceMessageID;
if (sourceMessageID) { if (sourceMessageID) {
rawThreadInfo = { ...rawThreadInfo, sourceMessageID }; rawThreadInfo = { ...rawThreadInfo, sourceMessageID };
} }
if (serverThreadInfo.avatar) { if (serverThreadInfo.avatar) {
rawThreadInfo = { ...rawThreadInfo, avatar: serverThreadInfo.avatar }; rawThreadInfo = { ...rawThreadInfo, avatar: serverThreadInfo.avatar };
} }
if (!excludePinInfo) { if (!excludePinInfo) {
return { rawThreadInfo = {
...rawThreadInfo, ...rawThreadInfo,
pinnedCount: serverThreadInfo.pinnedCount, pinnedCount: serverThreadInfo.pinnedCount,
}; };
} }
return rawThreadInfo; return shouldMinimallyEncodePermissions
? minimallyEncodeRawThreadInfo(rawThreadInfo)
: rawThreadInfo;
} }
function threadUIName(threadInfo: ThreadInfo): string | ThreadEntity { function threadUIName(threadInfo: ThreadInfo): string | ThreadEntity {
if (threadInfo.name) { if (threadInfo.name) {
return firstLine(threadInfo.name); return firstLine(threadInfo.name);
} }
let threadMembers: $ReadOnlyArray<RelativeMemberInfo>; let threadMembers: $ReadOnlyArray<RelativeMemberInfo>;
▲ Show 20 Lines • Show All 1,000 Lines • Show Last 20 Lines
View Options

native/profile/secondary-device-qr-code-scanner.react.js

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines
} from '../types/message-types.js'; } from '../types/message-types.js';
import type { import type {
MinimallyEncodedRawThreadInfo, MinimallyEncodedRawThreadInfo,
MinimallyEncodedThreadCurrentUserInfo, MinimallyEncodedThreadCurrentUserInfo,
MinimallyEncodedThreadInfo, MinimallyEncodedThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import { import {
decodeMinimallyEncodedRoleInfo, decodeMinimallyEncodedRoleInfo,
minimallyEncodeRawThreadInfo,
minimallyEncodeThreadInfo, minimallyEncodeThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { import {
threadPermissionPropagationPrefixes, threadPermissionPropagationPrefixes,
threadPermissions, threadPermissions,
configurableCommunityPermissions, configurableCommunityPermissions,
type ThreadPermission, type ThreadPermission,
▲ Show 20 Lines • Show All 655 Lines • ▼ Show 20 Linesasync function createRealThreadFromPendingThread({
return newThreadID; return newThreadID;
} }
type RawThreadInfoOptions = { type RawThreadInfoOptions = {
+filterThreadEditAvatarPermission?: boolean, +filterThreadEditAvatarPermission?: boolean,
+excludePinInfo?: boolean, +excludePinInfo?: boolean,
+filterManageInviteLinksPermission?: boolean, +filterManageInviteLinksPermission?: boolean,
+filterVoicedInAnnouncementChannelsPermission?: boolean, +filterVoicedInAnnouncementChannelsPermission?: boolean,
+minimallyEncodePermissions?: boolean,
}; };
function rawThreadInfoFromServerThreadInfo( function rawThreadInfoFromServerThreadInfo(
serverThreadInfo: ServerThreadInfo, serverThreadInfo: ServerThreadInfo,
viewerID: string, viewerID: string,
options?: RawThreadInfoOptions, options?: RawThreadInfoOptions,
): ?LegacyRawThreadInfo { ): ?RawThreadInfo {
const filterThreadEditAvatarPermission = const filterThreadEditAvatarPermission =
options?.filterThreadEditAvatarPermission; options?.filterThreadEditAvatarPermission;
const excludePinInfo = options?.excludePinInfo; const excludePinInfo = options?.excludePinInfo;
const filterManageInviteLinksPermission = const filterManageInviteLinksPermission =
options?.filterManageInviteLinksPermission; options?.filterManageInviteLinksPermission;
const filterVoicedInAnnouncementChannelsPermission = const filterVoicedInAnnouncementChannelsPermission =
options?.filterVoicedInAnnouncementChannelsPermission; options?.filterVoicedInAnnouncementChannelsPermission;
const shouldMinimallyEncodePermissions = options?.minimallyEncodePermissions;
const filterThreadPermissions = _omitBy( const filterThreadPermissions = _omitBy(
(v, k) => (v, k) =>
(filterThreadEditAvatarPermission && (filterThreadEditAvatarPermission &&
[ [
threadPermissions.EDIT_THREAD_AVATAR, threadPermissions.EDIT_THREAD_AVATAR,
threadPermissionPropagationPrefixes.DESCENDANT + threadPermissionPropagationPrefixes.DESCENDANT +
threadPermissions.EDIT_THREAD_AVATAR, threadPermissions.EDIT_THREAD_AVATAR,
▲ Show 20 Lines • Show All 88 Lines • ▼ Show 20 Lines): ?RawThreadInfo {
const sourceMessageID = serverThreadInfo.sourceMessageID; const sourceMessageID = serverThreadInfo.sourceMessageID;
if (sourceMessageID) { if (sourceMessageID) {
rawThreadInfo = { ...rawThreadInfo, sourceMessageID }; rawThreadInfo = { ...rawThreadInfo, sourceMessageID };
} }
if (serverThreadInfo.avatar) { if (serverThreadInfo.avatar) {
rawThreadInfo = { ...rawThreadInfo, avatar: serverThreadInfo.avatar }; rawThreadInfo = { ...rawThreadInfo, avatar: serverThreadInfo.avatar };
} }
if (!excludePinInfo) { if (!excludePinInfo) {
return { rawThreadInfo = {
...rawThreadInfo, ...rawThreadInfo,
pinnedCount: serverThreadInfo.pinnedCount, pinnedCount: serverThreadInfo.pinnedCount,
}; };
} }
return rawThreadInfo; return shouldMinimallyEncodePermissions
? minimallyEncodeRawThreadInfo(rawThreadInfo)
: rawThreadInfo;
} }
function threadUIName(threadInfo: ThreadInfo): string | ThreadEntity { function threadUIName(threadInfo: ThreadInfo): string | ThreadEntity {
if (threadInfo.name) { if (threadInfo.name) {
return firstLine(threadInfo.name); return firstLine(threadInfo.name);
} }
let threadMembers: $ReadOnlyArray<RelativeMemberInfo>; let threadMembers: $ReadOnlyArray<RelativeMemberInfo>;
▲ Show 20 Lines • Show All 1,000 Lines • Show Last 20 Lines