Page MenuHomePhabricator

[lib] refresh device lists after restore
AbandonedPublic

Authored by kamil on Jun 10 2024, 9:37 AM.
Tags
None
Referenced Files
F3381526: D12383.diff
Thu, Nov 28, 5:22 AM
Unknown Object (File)
Sun, Nov 24, 9:40 PM
Unknown Object (File)
Sun, Nov 24, 7:33 PM
Unknown Object (File)
Wed, Nov 20, 2:40 PM
Unknown Object (File)
Wed, Nov 20, 2:40 PM
Unknown Object (File)
Sat, Nov 2, 12:07 AM
Unknown Object (File)
Sat, Nov 2, 12:07 AM
Unknown Object (File)
Fri, Nov 1, 11:43 PM
Subscribers

Details

Reviewers
bartek
tomek
Summary

After restoring the backup device can have outdated device lists, the easiest way to fix this is to remove device lists and D12330 will automatically re-fetch data from Identity, and also D12382 will create new olm sessions.

Depends on D12381

Test Plan
  1. Not testing restore/backup
  2. Dispatch action and test if device lists are cleared and refreshed

Diff Detail

Repository
rCOMM Comm
Branch
peer-list-4
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Jun 10 2024, 9:53 AM
tomek added inline comments.
lib/hooks/qr-auth.js
131–136

This doesn't make too much sense to me. If we want to remove the device lists after restoration, shouldn't we simply not persist them?

We've discussed this with @kamil and it seems like this solution is better than its alternatives.

This revision is now accepted and ready to land.Jun 13 2024, 3:46 AM