[lib] make `signedDeviceList` in `DEVICE_LIST_UPDATED` message optional
ClosedPublic
Actions

Authored by kamil on Jun 7 2024, 2:26 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM36192d5aac81: [lib] make `signedDeviceList` in `DEVICE_LIST_UPDATED` message optional

Summary

To standardize sending updates for all Identity auth (legacy/QR-code) we need to remove signedDeviceList. However, @bartek added additional check for broadcasted and Identity device list equality and we want to keep it for now.

Depends on D12330

Test Plan

Flow - functionality tested later in the stack.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jun 7 2024, 2:26 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 7 2024, 2:26 AM

Harbormaster failed remote builds in B29520: Diff 41093!Jun 7 2024, 2:31 AM

kamil published this revision for review.Jun 7 2024, 2:39 AM

bartek accepted this revision.Jun 7 2024, 4:25 AM

bartek added inline comments.

lib/handlers/peer-to-peer-message-handler.js
179–185 ↗	(On Diff #41093)	Yeah it's good to leave this check for debugging device list updates. Finally, it will be a non-breaking change to remove `signedDeviceList` from the message type.