Page MenuHomePhabricator
Differential D12441

Rename new_content_prekeys and new_notif_prekeys
ClosedPublic
Actions

Authored by varun on Jun 14 2024, 8:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 28 2025, 2:26 PM
Unknown Object (File)
Feb 28 2025, 2:25 PM
Unknown Object (File)
Feb 20 2025, 9:08 AM
Unknown Object (File)
Feb 20 2025, 2:22 AM
Unknown Object (File)
Feb 6 2025, 9:07 AM
Unknown Object (File)
Feb 3 2025, 2:33 PM
Unknown Object (File)
Feb 3 2025, 11:13 AM
Unknown Object (File)
Jan 30 2025, 2:54 PM
View All 71 Files
Subscribers
tomek

Details

Reviewers
bartek
ashoat
Commits
rCOMM284294086cce: Rename new_content_prekeys and new_notif_prekeys
Summary

We only upload one of each type of prekey, so these fields should not be plural

Depends on D12436

Test Plan

ran flow, checked all invocations of RefreshUserPrekeys to make sure client code reflected the field name changes

Diff Detail

Repository
rCOMM Comm
Branch
webping (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jun 14 2024, 8:48 AM
Herald added a subscriber: tomek. · View Herald TranscriptJun 14 2024, 8:48 AM
varun updated this revision to Diff 41340.Jun 14 2024, 8:56 AM

fix variable names in identity

shared/protos/identity_auth.proto
86–92

keep lines under 80 characters

shared/protos/identity_unauth.proto
70–71

unrelated formatting change to match style guide

Harbormaster failed remote builds in B29686: Diff 41339!Jun 14 2024, 9:11 AM
Harbormaster completed remote builds in B29687: Diff 41340.
varun requested review of this revision.Jun 14 2024, 9:13 AM
varun added a child revision: D12442: [keyserver] check if there are any unpublished prekeys and publish them during rotation.Jun 14 2024, 9:40 AM
ashoat accepted this revision.Jun 14 2024, 2:39 PM

Proto changes won't break compatibility, right?

This revision is now accepted and ready to land.Jun 14 2024, 2:39 PM
varun added a comment.Jun 17 2024, 9:38 AM
In D12441#353079, @ashoat wrote:

Proto changes won't break compatibility, right?

they will. we need to do a new staging release right after this stack is landed. we will also need to do a new keyserver release when we do the next identity prod release

Closed by commit rCOMM284294086cce: Rename new_content_prekeys and new_notif_prekeys (authored by varun). · Explain WhyJun 17 2024, 9:47 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM284294086cce: Rename new_content_prekeys and new_notif_prekeys.
ashoat added a comment.EditedJun 17 2024, 9:56 AM

we will also need to do a new keyserver release when we do the next identity prod release

Next keyserver release includes a major migration that will probs take 15-30min to process, so I'm planning to do it late at night. Does that mean the identity release needs to happen late at night as well? Will any bad things happen if I deploy keyserver without identity being updated as well?

varun added a comment.Jun 17 2024, 11:10 AM
In D12441#353480, @ashoat wrote:

we will also need to do a new keyserver release when we do the next identity prod release

Next keyserver release includes a major migration that will probs take 15-30min to process, so I'm planning to do it late at night. Does that mean the identity release needs to happen late at night as well? Will any bad things happen if I deploy keyserver without identity being updated as well?

your keyserver will not be able to send new prekeys to identity during prekey rotation if you deploy keyserver without identity being updated as well. maybe this is fine? we could manually run the prekey rotation cron job the following morning after we do the identity prod release. we could also exclude this commit (2842940) from the keyserver release and then do a separate keyserver release with just this commit during the day at the same time as the identity prod release

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
src/
identity_client/
4 lines
native/
native_rust_library/
src/
identity/
4 lines
services/
commtest/
tests/
4 lines
identity/
src/
grpc_services/
8 lines
shared/
protos/
10 lines
3 lines
web/
grpc/
4 lines
protobufs/
20 lines

Diff 41340

View Options

keyserver/addons/rust-node-addon/src/identity_client/prekey.rs

// @flow // @flow
import type { import type {
FetchInviteLinksResponse, FetchInviteLinksResponse,
InviteLinkVerificationRequest, InviteLinkVerificationRequest,
InviteLinkVerificationResponse, InviteLinkVerificationResponse,
CreateOrUpdatePublicLinkRequest, CreateOrUpdatePublicLinkRequest,
InviteLink, InviteLink,
DisableInviteLinkRequest,
DisableInviteLinkPayload,
} from '../types/link-types.js'; } from '../types/link-types.js';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
const verifyInviteLinkActionTypes = Object.freeze({ const verifyInviteLinkActionTypes = Object.freeze({
started: 'VERIFY_INVITE_LINK_STARTED', started: 'VERIFY_INVITE_LINK_STARTED',
success: 'VERIFY_INVITE_LINK_SUCCESS', success: 'VERIFY_INVITE_LINK_SUCCESS',
failed: 'VERIFY_INVITE_LINK_FAILED', failed: 'VERIFY_INVITE_LINK_FAILED',
}); });
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines return {
role: response.role, role: response.role,
communityID: response.communityID, communityID: response.communityID,
expirationTime: response.expirationTime, expirationTime: response.expirationTime,
limitOfUses: response.limitOfUses, limitOfUses: response.limitOfUses,
numberOfUses: response.numberOfUses, numberOfUses: response.numberOfUses,
}; };
}; };
const disableInviteLinkLinkActionTypes = Object.freeze({
started: 'DISABLE_INVITE_LINK_STARTED',
success: 'DISABLE_INVITE_LINK_SUCCESS',
failed: 'DISABLE_INVITE_LINK_FAILED',
});
const disableInviteLink =
(
callServerEndpoint: CallServerEndpoint,
): ((
request: DisableInviteLinkRequest,
) => Promise<DisableInviteLinkPayload>) =>
async request => {
await callServerEndpoint('disable_invite_link', request);
return {
name: request.name,
communityID: request.communityID,
};
};
export { export {
verifyInviteLinkActionTypes, verifyInviteLinkActionTypes,
verifyInviteLink, verifyInviteLink,
fetchPrimaryInviteLinkActionTypes, fetchPrimaryInviteLinkActionTypes,
fetchPrimaryInviteLinks, fetchPrimaryInviteLinks,
createOrUpdatePublicLinkActionTypes, createOrUpdatePublicLinkActionTypes,
createOrUpdatePublicLink, createOrUpdatePublicLink,
disableInviteLinkLinkActionTypes,
disableInviteLink,
}; };
View Options

native/native_rust_library/src/identity/x3dh.rs

// @flow // @flow
import type { import type {
FetchInviteLinksResponse, FetchInviteLinksResponse,
InviteLinkVerificationRequest, InviteLinkVerificationRequest,
InviteLinkVerificationResponse, InviteLinkVerificationResponse,
CreateOrUpdatePublicLinkRequest, CreateOrUpdatePublicLinkRequest,
InviteLink, InviteLink,
DisableInviteLinkRequest,
DisableInviteLinkPayload,
} from '../types/link-types.js'; } from '../types/link-types.js';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
const verifyInviteLinkActionTypes = Object.freeze({ const verifyInviteLinkActionTypes = Object.freeze({
started: 'VERIFY_INVITE_LINK_STARTED', started: 'VERIFY_INVITE_LINK_STARTED',
success: 'VERIFY_INVITE_LINK_SUCCESS', success: 'VERIFY_INVITE_LINK_SUCCESS',
failed: 'VERIFY_INVITE_LINK_FAILED', failed: 'VERIFY_INVITE_LINK_FAILED',
}); });
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines return {
role: response.role, role: response.role,
communityID: response.communityID, communityID: response.communityID,
expirationTime: response.expirationTime, expirationTime: response.expirationTime,
limitOfUses: response.limitOfUses, limitOfUses: response.limitOfUses,
numberOfUses: response.numberOfUses, numberOfUses: response.numberOfUses,
}; };
}; };
const disableInviteLinkLinkActionTypes = Object.freeze({
started: 'DISABLE_INVITE_LINK_STARTED',
success: 'DISABLE_INVITE_LINK_SUCCESS',
failed: 'DISABLE_INVITE_LINK_FAILED',
});
const disableInviteLink =
(
callServerEndpoint: CallServerEndpoint,
): ((
request: DisableInviteLinkRequest,
) => Promise<DisableInviteLinkPayload>) =>
async request => {
await callServerEndpoint('disable_invite_link', request);
return {
name: request.name,
communityID: request.communityID,
};
};
export { export {
verifyInviteLinkActionTypes, verifyInviteLinkActionTypes,
verifyInviteLink, verifyInviteLink,
fetchPrimaryInviteLinkActionTypes, fetchPrimaryInviteLinkActionTypes,
fetchPrimaryInviteLinks, fetchPrimaryInviteLinks,
createOrUpdatePublicLinkActionTypes, createOrUpdatePublicLinkActionTypes,
createOrUpdatePublicLink, createOrUpdatePublicLink,
disableInviteLinkLinkActionTypes,
disableInviteLink,
}; };
View Options

services/commtest/tests/identity_prekey_tests.rs

// @flow // @flow
import type { import type {
FetchInviteLinksResponse, FetchInviteLinksResponse,
InviteLinkVerificationRequest, InviteLinkVerificationRequest,
InviteLinkVerificationResponse, InviteLinkVerificationResponse,
CreateOrUpdatePublicLinkRequest, CreateOrUpdatePublicLinkRequest,
InviteLink, InviteLink,
DisableInviteLinkRequest,
DisableInviteLinkPayload,
} from '../types/link-types.js'; } from '../types/link-types.js';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
const verifyInviteLinkActionTypes = Object.freeze({ const verifyInviteLinkActionTypes = Object.freeze({
started: 'VERIFY_INVITE_LINK_STARTED', started: 'VERIFY_INVITE_LINK_STARTED',
success: 'VERIFY_INVITE_LINK_SUCCESS', success: 'VERIFY_INVITE_LINK_SUCCESS',
failed: 'VERIFY_INVITE_LINK_FAILED', failed: 'VERIFY_INVITE_LINK_FAILED',
}); });
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines return {
role: response.role, role: response.role,
communityID: response.communityID, communityID: response.communityID,
expirationTime: response.expirationTime, expirationTime: response.expirationTime,
limitOfUses: response.limitOfUses, limitOfUses: response.limitOfUses,
numberOfUses: response.numberOfUses, numberOfUses: response.numberOfUses,
}; };
}; };
const disableInviteLinkLinkActionTypes = Object.freeze({
started: 'DISABLE_INVITE_LINK_STARTED',
success: 'DISABLE_INVITE_LINK_SUCCESS',
failed: 'DISABLE_INVITE_LINK_FAILED',
});
const disableInviteLink =
(
callServerEndpoint: CallServerEndpoint,
): ((
request: DisableInviteLinkRequest,
) => Promise<DisableInviteLinkPayload>) =>
async request => {
await callServerEndpoint('disable_invite_link', request);
return {
name: request.name,
communityID: request.communityID,
};
};
export { export {
verifyInviteLinkActionTypes, verifyInviteLinkActionTypes,
verifyInviteLink, verifyInviteLink,
fetchPrimaryInviteLinkActionTypes, fetchPrimaryInviteLinkActionTypes,
fetchPrimaryInviteLinks, fetchPrimaryInviteLinks,
createOrUpdatePublicLinkActionTypes, createOrUpdatePublicLinkActionTypes,
createOrUpdatePublicLink, createOrUpdatePublicLink,
disableInviteLinkLinkActionTypes,
disableInviteLink,
}; };
View Options

services/identity/src/grpc_services/authenticated.rs

// @flow // @flow
import type { import type {
FetchInviteLinksResponse, FetchInviteLinksResponse,
InviteLinkVerificationRequest, InviteLinkVerificationRequest,
InviteLinkVerificationResponse, InviteLinkVerificationResponse,
CreateOrUpdatePublicLinkRequest, CreateOrUpdatePublicLinkRequest,
InviteLink, InviteLink,
DisableInviteLinkRequest,
DisableInviteLinkPayload,
} from '../types/link-types.js'; } from '../types/link-types.js';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
const verifyInviteLinkActionTypes = Object.freeze({ const verifyInviteLinkActionTypes = Object.freeze({
started: 'VERIFY_INVITE_LINK_STARTED', started: 'VERIFY_INVITE_LINK_STARTED',
success: 'VERIFY_INVITE_LINK_SUCCESS', success: 'VERIFY_INVITE_LINK_SUCCESS',
failed: 'VERIFY_INVITE_LINK_FAILED', failed: 'VERIFY_INVITE_LINK_FAILED',
}); });
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines return {
role: response.role, role: response.role,
communityID: response.communityID, communityID: response.communityID,
expirationTime: response.expirationTime, expirationTime: response.expirationTime,
limitOfUses: response.limitOfUses, limitOfUses: response.limitOfUses,
numberOfUses: response.numberOfUses, numberOfUses: response.numberOfUses,
}; };
}; };
const disableInviteLinkLinkActionTypes = Object.freeze({
started: 'DISABLE_INVITE_LINK_STARTED',
success: 'DISABLE_INVITE_LINK_SUCCESS',
failed: 'DISABLE_INVITE_LINK_FAILED',
});
const disableInviteLink =
(
callServerEndpoint: CallServerEndpoint,
): ((
request: DisableInviteLinkRequest,
) => Promise<DisableInviteLinkPayload>) =>
async request => {
await callServerEndpoint('disable_invite_link', request);
return {
name: request.name,
communityID: request.communityID,
};
};
export { export {
verifyInviteLinkActionTypes, verifyInviteLinkActionTypes,
verifyInviteLink, verifyInviteLink,
fetchPrimaryInviteLinkActionTypes, fetchPrimaryInviteLinkActionTypes,
fetchPrimaryInviteLinks, fetchPrimaryInviteLinks,
createOrUpdatePublicLinkActionTypes, createOrUpdatePublicLinkActionTypes,
createOrUpdatePublicLink, createOrUpdatePublicLink,
disableInviteLinkLinkActionTypes,
disableInviteLink,
}; };
View Options

shared/protos/identity_auth.proto

// @flow // @flow
import type { import type {
FetchInviteLinksResponse, FetchInviteLinksResponse,
InviteLinkVerificationRequest, InviteLinkVerificationRequest,
InviteLinkVerificationResponse, InviteLinkVerificationResponse,
CreateOrUpdatePublicLinkRequest, CreateOrUpdatePublicLinkRequest,
InviteLink, InviteLink,
DisableInviteLinkRequest,
DisableInviteLinkPayload,
} from '../types/link-types.js'; } from '../types/link-types.js';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
const verifyInviteLinkActionTypes = Object.freeze({ const verifyInviteLinkActionTypes = Object.freeze({
started: 'VERIFY_INVITE_LINK_STARTED', started: 'VERIFY_INVITE_LINK_STARTED',
success: 'VERIFY_INVITE_LINK_SUCCESS', success: 'VERIFY_INVITE_LINK_SUCCESS',
failed: 'VERIFY_INVITE_LINK_FAILED', failed: 'VERIFY_INVITE_LINK_FAILED',
}); });
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines return {
role: response.role, role: response.role,
communityID: response.communityID, communityID: response.communityID,
expirationTime: response.expirationTime, expirationTime: response.expirationTime,
limitOfUses: response.limitOfUses, limitOfUses: response.limitOfUses,
numberOfUses: response.numberOfUses, numberOfUses: response.numberOfUses,
}; };
}; };
const disableInviteLinkLinkActionTypes = Object.freeze({
started: 'DISABLE_INVITE_LINK_STARTED',
success: 'DISABLE_INVITE_LINK_SUCCESS',
failed: 'DISABLE_INVITE_LINK_FAILED',
});
const disableInviteLink =
(
callServerEndpoint: CallServerEndpoint,
): ((
request: DisableInviteLinkRequest,
) => Promise<DisableInviteLinkPayload>) =>
async request => {
await callServerEndpoint('disable_invite_link', request);
return {
name: request.name,
communityID: request.communityID,
};
};
export { export {
verifyInviteLinkActionTypes, verifyInviteLinkActionTypes,
verifyInviteLink, verifyInviteLink,
fetchPrimaryInviteLinkActionTypes, fetchPrimaryInviteLinkActionTypes,
fetchPrimaryInviteLinks, fetchPrimaryInviteLinks,
createOrUpdatePublicLinkActionTypes, createOrUpdatePublicLinkActionTypes,
createOrUpdatePublicLink, createOrUpdatePublicLink,
disableInviteLinkLinkActionTypes,
disableInviteLink,
}; };
View Options

shared/protos/identity_unauth.proto

Loading...
View Options

web/grpc/identity-service-client-wrapper.js

Loading...
View Options

web/protobufs/identity-auth-structs.cjs

Loading...
View Options

web/protobufs/identity-auth-structs.cjs.flow

Loading...