Page MenuHomePhabricator

[lib] Remove `member.permissions` from `RawThreadInfo` test data
AbandonedPublic

Authored by atul on Jun 18 2024, 1:33 PM.
Tags
None
Referenced Files
F3349999: D12470.diff
Fri, Nov 22, 8:10 PM
Unknown Object (File)
Sat, Nov 9, 1:44 AM
Unknown Object (File)
Fri, Nov 1, 9:30 PM
Unknown Object (File)
Wed, Oct 30, 12:35 AM
Unknown Object (File)
Oct 23 2024, 7:22 PM
Unknown Object (File)
Oct 23 2024, 7:22 PM
Unknown Object (File)
Oct 18 2024, 3:05 PM
Unknown Object (File)
Sep 30 2024, 3:08 PM
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Summary

There are places in unit tests where we construct RawThreadInfo.members and include permissions field. This diff just handles removing the permissions field from test data to reduce flow issues from ~64 -> ~36.


Depends on D12469

Test Plan

NA, reduced flow issues and tests continue to pass

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 18 2024, 1:46 PM
Harbormaster failed remote builds in B29760: Diff 41468!
atul requested review of this revision.Jun 18 2024, 4:03 PM

Abandoning in favor of stack starting with D12594 because lots of things have changed and there's not really 1:1 correspondence with old stack and new stack so I don't think it makes sense to update in place, change a bunch of child/parent diff relationships, etc.