[lib] Fix construction of `RawThreadInfo` in `createPendingThread`
AbandonedPublic
Actions

Authored by atul on Jun 18 2024, 8:27 PM.

Details

Reviewers

ashoat
ginsu
tomek

Summary

Part of resolving the flow issues introduced in D12469.

Depends on D12470

Test Plan

NA, went from ~36 -> ~26 flow issues.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 18 2024, 8:27 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 18 2024, 8:40 PM

Harbormaster failed remote builds in B29767: Diff 41477!

atul requested review of this revision.Jun 19 2024, 1:42 PM

atul added a child revision: D12502: [lib] Resolve `flow` issues in `getRelativeMemberInfos`.Jun 19 2024, 8:27 PM

Abandoning in favor of stack starting with D12594 because lots of things have changed and there's not really 1:1 correspondence with old stack and new stack so I don't think it makes sense to update in place, change a bunch of child/parent diff relationships, etc.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

14 lines

Diff 41477

View Options

lib/shared/thread-utils.js

Show First 20 Lines • Show All 263 Lines • ▼ Show 20 Lines	unsafe extern "C++" {
fn get_backup_directory_path() -> Result<String>;		fn get_backup_directory_path() -> Result<String>;

#[allow(unused)]		#[allow(unused)]
#[cxx_name = "getBackupFilePath"]		#[cxx_name = "getBackupFilePath"]
fn get_backup_file_path(		fn get_backup_file_path(
backup_id: String,		backup_id: String,
is_attachments: bool,		is_attachments: bool,
) -> Result<String>;		) -> Result<String>;

		#[allow(unused)]
		#[cxx_name = "createMainCompaction"]
		fn create_main_compaction(backup_id: String) -> Result<()>;

		#[allow(unused)]
		#[cxx_name = "restoreFromMainCompaction"]
		fn restore_from_main_compaction(
		main_compaction_path: String,
		main_compaction_encryption_key: String,
		) -> Result<()>;
}		}
}		}

fn handle_string_result_as_callback<E>(		fn handle_string_result_as_callback<E>(
result: Result<String, E>,		result: Result<String, E>,
promise_id: u32,		promise_id: u32,
) where		) where
E: std::fmt::Display,		E: std::fmt::Display,
▲ Show 20 Lines • Show All 896 Lines • Show Last 20 Lines

[lib] Fix construction of `RawThreadInfo` in `createPendingThread`AbandonedPublicActions