Paths

Table of Contentst

Differential D12597

[lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`
AcceptedPublic
Actions

Authored by atul on Thu, Jun 27, 1:19 PM.

Tags

None

Referenced Files

	F2185856: D12597.id41771.diff
	Thu, Jul 4, 1:19 AM

	F2185689: D12597.id41769.diff
	Thu, Jul 4, 12:40 AM

	F2185615: D12597.id41771.diff
	Thu, Jul 4, 12:27 AM

	F2179192: D12597.id41769.diff
	Wed, Jul 3, 12:09 PM

	F2175857: D12597.id41771.diff
	Wed, Jul 3, 3:26 AM

	F2175511: D12597.diff
	Wed, Jul 3, 2:50 AM

	Unknown Object (File)
	Tue, Jul 2, 12:40 AM

	Unknown Object (File)
	Mon, Jul 1, 11:47 PM

View All 13 Files

Subscribers

Details

Reviewers

Summary

Part of resolving the flow issues introduced (intentionally) in D12594.

IMPORTANT: This is used on client to create NEW *RawThreadInfos which is persisted representation. We want to make sure this change is landed in same release as migration so we don't end up having *RawThreadInfos with/without member permissions persisted before migration.

Depends on D12594

Test Plan

Create new threads on native/web client and ensure that ThinRawThreadInfos are created/persisted without member permissions.

NOTE: 6 remaining flow issues expected.

Diff Detail

Repository

Branch

july26 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Thu, Jun 27, 1:19 PM

Herald added a subscriber: tomek. · View Herald TranscriptThu, Jun 27, 1:19 PM

atul edited the test plan for this revision. (Show Details)Thu, Jun 27, 1:20 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Jun 27, 1:32 PM

Harbormaster failed remote builds in B29970: Diff 41769!

atul requested review of this revision.Thu, Jun 27, 1:42 PM

atul added a child revision: D12598: [lib] Deprecate `decodeMinimallyEncodedRawThreadInfo`.Thu, Jun 27, 1:44 PM

remove extraneous import

Harbormaster failed remote builds in B29972: Diff 41771!Thu, Jun 27, 2:00 PM

ashoat accepted this revision.Mon, Jul 1, 1:09 PM

This revision is now accepted and ready to land.Mon, Jul 1, 1:09 PM

ashoat mentioned this in D12594: [lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.Mon, Jul 1, 1:09 PM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

14 lines

Diff 41769

lib/shared/thread-utils.js

Loading...