Differential D12598
[lib] Deprecate `decodeMinimallyEncodedRawThreadInfo` Authored by atul on Jun 27 2024, 1:44 PM. Tags None Referenced Files
Subscribers
Details This function is used in 3 places:
We will deprecate updateRolesAndPermissions in subsequent diff in this stack, at which point this function will only be relevant for keeping existing "legacy" migrations functional. It will not and should NOT be used for migrations going forward because there are no encoded member permissions to be decoded in future persisted *RawThreadInfo. Depends on D12597 This diff is just a rename, will add flow suppression in next diff. Looked at all callsites and made sure there's nothing preventing function from being deprecated.
Diff Detail
Event TimelineComment Actions Is the idea here that we'll never need to decode the permissions on RawThreadInfo again, since we don't store the permissions on the client? How about all the other decode* and encode* functions – should those be marked as deprecated as well? Comment Actions It's possible we may want to decode RawThreadInfos in the future, but we can re-introduce a new utility at that point that handles roles and currentUser and skips members which won't have stored permissions.
Motivation for deprecating these was flow-related, specifically the change to the *RawThreadInfo type. There's no immediate need to deprecate the others. |