Details

Reviewers

Commits

rCOMM0561cfa7544f: [lib] Change type of `ThinRawThreadInfo.members` from…

Summary

Start of stack replacing stack that started with D12469.

This diff makes the change to ThinRawThreadInfo.members which intentionally introduces flow issues which will be addressed in the rest of the stack.

Also snuck in stripping out MemberInfo.permissions from test data to reduce flow noise.

We're at 5 flow issues instead of the ~64 we had after D12469. Think this is largely due to stack ending in D12496, but will check each of the places with flow issues in previous stack to make sure nothing is broken quietly.

Depends on D12554

Test Plan

NA, flow.

This change ONLY changes flow types. We still need to update validators, persisted data, keyserver endpoint, client migrations, etc. which will be handled in subsequent diffs.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 27 2024, 12:31 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2024, 12:31 PM

atul mentioned this in D12469: [lib] Change type of `RawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.Jun 27 2024, 12:32 PM

atul mentioned this in D12470: [lib] Remove `member.permissions` from `RawThreadInfo` test data.

atul mentioned this in D12472: [lib] Fix construction of `RawThreadInfo` in `createPendingThread`.

atul mentioned this in D12502: [lib] Resolve `flow` issues in `getRelativeMemberInfos`.

atul mentioned this in D12557: [lib] Change return type of `minimallyEncodeRawThreadInfo` to `RawThreadInfoWithMemberPermissions`.Jun 27 2024, 12:37 PM

atul mentioned this in D12573: [lib] Change `decodeMinimallyEncodedRawThreadInfo` argument type to `RawThreadInfoWithMemberPermissions`.

atul mentioned this in D12574: [native] Add `$FlowIgnore` annotation to migration 61.

Some reminders to myself from abandoned stack that stack starting with this diff will replace:

https://phab.comm.dev/D12557#356476
https://phab.comm.dev/D12574#356485

will need to update validator AND make sure we have validators for previous/new ThinRawThreadInfo.members included in convertClientDBThreadInfoToRawThreadInfo to avoid breaking clients. This is crucial because convertClientDBThreadInfoToRawThreadInfo is run once upon client upgrade before migrations in persist.jsare run. This is what broke things with removing .isDefault migration.

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 27 2024, 12:44 PM

Harbormaster failed remote builds in B29967: Diff 41766!

atul requested review of this revision.Jun 27 2024, 12:45 PM

atul added inline comments.

lib/types/minimally-encoded-thread-permissions-types.js
174 ↗	(On Diff #41766)	Actual non-test data related change.

atul added a child revision: D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.Jun 27 2024, 1:19 PM

This diff just changes the types, but I'm curious about the actual data. Is there going to be a migration later to strip this data from the client, alongside the createPendingThread changes in D12597?

This revision is now accepted and ready to land.Jul 1 2024, 1:09 PM

resolve merge conflict

Harbormaster failed remote builds in B30229: Diff 42152!Jul 9 2024, 11:10 AM

rebase after resequence

Harbormaster failed remote builds in B30243: Diff 42177!Jul 9 2024, 2:15 PM

rebase, look like there are no ESLint issues. There's failing validator that gets fixed in later diff... though maybe it makes sense to cherry-pick D12758 and land it to resolve failing validator test for rest of stack.

Harbormaster failed remote builds in B30428: Diff 42401!Jul 17 2024, 12:53 PM

Hmm looks like a bunch of Flow errors

This revision now requires changes to proceed.Jul 17 2024, 1:02 PM

In D12594#361908, @ashoat wrote:

Hmm looks like a bunch of Flow errors

This diff was specifically to induce the flow issues which get resolved by subsequent diffs in stack.

We're at 5 flow issues instead of the ~64 we had after D12469. Think this is largely due to stack ending in D12496, but will check each of the places with flow issues in previous stack to make sure nothing is broken quietly.

Ah okay, sorry I missed that

This revision is now accepted and ready to land.Jul 17 2024, 1:13 PM

rebase after landing validator fix.

Harbormaster failed remote builds in B30432: Diff 42408!Jul 17 2024, 2:21 PM

rebase

Harbormaster failed remote builds in B30483: Diff 42485!Jul 18 2024, 12:53 PM

This revision was landed with ongoing or failed builds.Jul 18 2024, 1:37 PM

Closed by commit rCOMM0561cfa7544f: [lib] Change type of `ThinRawThreadInfo.members` from… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM0561cfa7544f: [lib] Change type of `ThinRawThreadInfo.members` from….

[lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 42401

lib/permissions/minimally-encoded-thread-permissions-test-data.js

lib/permissions/special-roles.test.js

lib/reducers/calendar-filters-reducer.test.js

lib/reducers/integrity-reducer.test.js

lib/shared/thread-utils.test.js

lib/types/minimally-encoded-thread-permissions-types.js

[lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42401

lib/permissions/minimally-encoded-thread-permissions-test-data.js

lib/permissions/special-roles.test.js

lib/reducers/calendar-filters-reducer.test.js

lib/reducers/integrity-reducer.test.js

lib/shared/thread-utils.test.js

lib/types/minimally-encoded-thread-permissions-types.js

[lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`
ClosedPublic
Actions

Revision Contents
Changeset List