Page MenuHomePhabricator
Differential D12787

[lib] Add `memberInfoSansPermissionsValidator` to `convertClientDBThreadInfoToRawThreadInfo`
ClosedPublic
Actions

Authored by atul on Jul 17 2024, 12:36 PM.
Tags
None
Referenced Files
F3350609: D12787.id42404.diff
Fri, Nov 22, 11:21 PM
F3350593: D12787.id42405.diff
Fri, Nov 22, 11:18 PM
Unknown Object (File)
Sat, Nov 9, 8:42 AM
Unknown Object (File)
Sun, Nov 3, 4:37 AM
Unknown Object (File)
Sat, Nov 2, 4:10 PM
Unknown Object (File)
Sat, Nov 2, 4:09 PM
Unknown Object (File)
Sat, Nov 2, 4:09 PM
Unknown Object (File)
Sat, Nov 2, 4:09 PM
View All 56 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM1a4d31715739: [lib] Add `memberInfoSansPermissionsValidator` to…
Summary

Added memberInfoSansPermissionsValidator to convertClientDBThreadInfoToRawThreadInfo.

In preparation for client migrations. Moved the more "relevant" validators earlier in conditional so we're doing (almost always) useless legacyMemberInfoValidator check all the time.

Depends on D12779

Test Plan

Will be tested implicitly by client migrations. We have unit tests for memberInfoSansPermissionsValidator.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jul 17 2024, 12:36 PM
Harbormaster completed remote builds in B30427: Diff 42400.Jul 17 2024, 12:53 PM
atul requested review of this revision.Jul 17 2024, 12:53 PM
ashoat accepted this revision.Jul 17 2024, 1:01 PM
This revision is now accepted and ready to land.Jul 17 2024, 1:01 PM
atul added a comment.Jul 17 2024, 1:47 PM

Can also cherry-pick and land this to simplify stack before rebasing and addressing all feedback.

atul updated this revision to Diff 42404.Jul 17 2024, 1:48 PM

cherry-pick and land

This revision was landed with ongoing or failed builds.Jul 17 2024, 1:52 PM
Closed by commit rCOMM1a4d31715739: [lib] Add `memberInfoSansPermissionsValidator` to… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM1a4d31715739: [lib] Add `memberInfoSansPermissionsValidator` to….
Harbormaster completed remote builds in B30430: Diff 42404.Jul 17 2024, 2:05 PM

Revision Contents
Changeset List

PathSize
lib/
utils/
8 lines

Diff 42405

View Options

lib/utils/thread-ops-utils.js

Loading...