Page MenuHomePhabricator
Differential D12597

[lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`
ClosedPublic
Actions

Authored by atul on Jun 27 2024, 1:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 24, 11:22 AM
Unknown Object (File)
Fri, Mar 21, 8:43 PM
Unknown Object (File)
Wed, Mar 12, 10:07 AM
Unknown Object (File)
Wed, Mar 12, 9:43 AM
Unknown Object (File)
Wed, Mar 12, 7:52 AM
Unknown Object (File)
Wed, Mar 12, 5:49 AM
Unknown Object (File)
Tue, Mar 11, 8:06 PM
Unknown Object (File)
Thu, Mar 6, 11:44 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM9fa6dd9ff9b7: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`
Summary

Part of resolving the flow issues introduced (intentionally) in D12594.

IMPORTANT: This is used on client to create NEW *RawThreadInfos which is persisted representation. We want to make sure this change is landed in same release as migration so we don't end up having *RawThreadInfos with/without member permissions persisted before migration.

Depends on D12594

Test Plan

Create new threads on native/web client and ensure that ThinRawThreadInfos are created/persisted without member permissions.

NOTE: 6 remaining flow issues expected.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 27 2024, 1:19 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2024, 1:19 PM
atul edited the test plan for this revision. (Show Details)Jun 27 2024, 1:20 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 27 2024, 1:32 PM
Harbormaster failed remote builds in B29970: Diff 41769!
atul requested review of this revision.Jun 27 2024, 1:42 PM
atul added a child revision: D12598: [lib] Deprecate `decodeMinimallyEncodedRawThreadInfo`.Jun 27 2024, 1:44 PM
atul updated this revision to Diff 41771.Jun 27 2024, 1:48 PM

remove extraneous import

Harbormaster failed remote builds in B29972: Diff 41771!Jun 27 2024, 2:00 PM
ashoat accepted this revision.Jul 1 2024, 1:09 PM
This revision is now accepted and ready to land.Jul 1 2024, 1:09 PM
ashoat mentioned this in D12594: [lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.Jul 1 2024, 1:09 PM
atul updated this revision to Diff 42153.Jul 9 2024, 10:58 AM

resolve merge conflict

Harbormaster failed remote builds in B30230: Diff 42153!Jul 9 2024, 11:11 AM
atul updated this revision to Diff 42178.Jul 9 2024, 2:07 PM

rebase after resequence

Harbormaster failed remote builds in B30244: Diff 42178!Jul 9 2024, 2:19 PM
atul added a child revision: D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.Jul 10 2024, 2:42 PM
atul added a child revision: D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.Jul 11 2024, 1:27 PM
atul removed a child revision: D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.Jul 15 2024, 11:31 AM
atul updated this revision to Diff 42409.Jul 17 2024, 2:09 PM

rebase after landing validator fix

atul updated this revision to Diff 42410.Jul 17 2024, 2:12 PM

fix ESLint issue

atul mentioned this in D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.Jul 17 2024, 2:14 PM
atul added a child revision: D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.Jul 17 2024, 2:18 PM
Harbormaster failed remote builds in B30433: Diff 42409!Jul 17 2024, 2:22 PM
Harbormaster failed remote builds in B30434: Diff 42410!
atul updated this revision to Diff 42486.Jul 18 2024, 12:40 PM

rebase

Harbormaster completed remote builds in B30484: Diff 42486.Jul 18 2024, 12:58 PM
atul added a comment.Jul 18 2024, 1:11 PM

It's actually fine to land this as-is. If migration runs on RawThreadInfo that's already missing permissions, nothing will happen since stripPermissionsFromMemberInfo just won't really do anything:

14695f.png (550×1 px, 105 KB)

atul updated this revision to Diff 42492.Jul 18 2024, 1:24 PM

cherry-pick and land

This revision was landed with ongoing or failed builds.Jul 18 2024, 1:37 PM
Closed by commit rCOMM9fa6dd9ff9b7: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM9fa6dd9ff9b7: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.
Harbormaster completed remote builds in B30490: Diff 42492.Jul 18 2024, 1:40 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
15 lines

Diff 42486

View Options

lib/shared/thread-utils.js

Show All 40 Linesfunction ManagePublicLinkScreen(props: Props): React.Node {
let errorComponent = null; let errorComponent = null;
if (error) { if (error) {
errorComponent = <Text style={styles.error}>{error}</Text>; errorComponent = <Text style={styles.error}>{error}</Text>;
} }
const onDisableButtonClick = React.useCallback(() => { const onDisableButtonClick = React.useCallback(() => {
Alert.alert( Alert.alert(
'Disable public link', 'Disable public link',
'Are you sure you want to disable your public link? Members who have your community’s public link but have not joined will not able to with the disabled link. \n' + 'Are you sure you want to disable your public link?\n' +
'\n' + '\n' +
'Other communities may also claim your previous public link url.', 'Other communities will be able to claim the same URL.',
[ [
{ {
text: 'Confirm disable', text: 'Confirm disable',
style: 'destructive', style: 'destructive',
onPress: disableInviteLink, onPress: disableInviteLink,
}, },
{ {
text: 'Cancel', text: 'Cancel',
Show All 18 Lines disablePublicLinkButton = (
</View> </View>
); );
} }
return ( return (
<View> <View>
<View style={styles.section}> <View style={styles.section}>
<Text style={styles.sectionText}> <Text style={styles.sectionText}>
Let your community be more accessible with your own unique public Invite links make it easy for your friends to join your community.
link. By enabling a public link, you are allowing anyone who has your Anybody who knows your community’s invite link will be able to join
link to join your community.{'\n\n'} it. Note that if you change your public link’s URL, other communities
Editing your community’s public link allows other communities to claim will be able to claim the old URL.
ashoatUnsubmitted
Not Done
Inline Actions

From the screenshot, this looks like too much text in a row. We could try separating out the third sentence into its own paragraph. We could also try showing the three sentences as three bullet points. @ted, any thoughts?

ashoat: From the screenshot, this looks like too much text in a row. We could try separating out the…
tomekAuthorUnsubmitted
Done
Inline Actions

In the original design, the last sentence was separated by an empty line. It probably makes sense to do the same here.

native-manage-newline.png (497×407 px, 38 KB)

tomek: In the original design, the last sentence was separated by an empty line. It probably makes…
your previous URL.
</Text> </Text>
</View> </View>
<Text style={styles.sectionTitle}>INVITE URL</Text> <Text style={styles.sectionTitle}>INVITE URL</Text>
<View style={styles.section}> <View style={styles.section}>
<View style={styles.inviteLink}> <View style={styles.inviteLink}>
<Text style={styles.inviteLinkPrefix}>{inviteLinkUrl('')}</Text> <Text style={styles.inviteLinkPrefix}>{inviteLinkUrl('')}</Text>
<TextInput <TextInput
style={styles.input} style={styles.input}
▲ Show 20 Lines • Show All 108 Lines • Show Last 20 Lines