[native] Introduce `native` migration to strip member permissions
ClosedPublic
Actions

Authored by atul on Jul 17 2024, 4:02 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM0748bce33c6f: [native] Introduce `native` migration to strip member permissions

Summary

Client side change to strip member permissions from persisted thread infos.

Depends on D12788

Test Plan

Ran migration on native client successfully:

Redux DevTools before:

Redux DevTools after:

Will do a couple more run-throughs on native to make sure everything is good.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jul 17 2024, 4:02 PM

atul edited the test plan for this revision. (Show Details)Jul 17 2024, 4:03 PM

atul added a child revision: D12790: [web] Introduce `web` migration to strip member permissions.Jul 17 2024, 4:09 PM

Harbormaster completed remote builds in B30447: Diff 42428.Jul 17 2024, 4:19 PM

atul requested review of this revision.Jul 17 2024, 4:19 PM

ashoat accepted this revision.Jul 18 2024, 12:12 PM

ashoat added inline comments.

native/redux/persist.js

1423–1426 ↗

(On Diff #42428)

Can we do something more explicit here?

// This isn't actually accurate, but we force this cast here because the
// types for createUpdateDBOpsForThreadStoreThreadInfos assume they're
// converting from a client DB that contains RawThreadInfos. In fact, at
// this point the client DB contains ThinRawThreadInfoWithPermissions.
const stripMemberPermissions: RawThreadInfos => RawThreadInfos =
  (stripMemberPermissionsFromRawThreadInfos: any);