Page MenuHomePhabricator

[native] Add message search store
ClosedPublic

Authored by inka on Jul 18 2024, 8:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 11:08 AM
Unknown Object (File)
Wed, Oct 23, 8:50 PM
Unknown Object (File)
Tue, Oct 22, 3:16 AM
Unknown Object (File)
Tue, Oct 22, 2:26 AM
Unknown Object (File)
Mon, Oct 14, 4:11 PM
Unknown Object (File)
Mon, Oct 14, 4:11 PM
Unknown Object (File)
Mon, Oct 14, 4:11 PM
Unknown Object (File)
Mon, Oct 14, 4:11 PM
Subscribers

Details

Summary

issue: ENG-8831

Test Plan

Tested with the next diff. Added an "add search message" operation on the js side and tested that updateMessageSearchIndex was run and no errors showed up in Metro nor in XCode console

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.Jul 18 2024, 8:24 AM
native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.cpp
9 ↗(On Diff #42471)

I will rename insert to update

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.cpp
16 ↗(On Diff #42471)

I might be missing something but I am confused why this function doesn't do anything. If it is intended to always return empty array then it is a good practice to declare jsiSearchMessages as static to avoid recomputing this variable upon each call to this function.

You need to add this to Cmake - example in D11509

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.cpp
16 ↗(On Diff #42471)

It will return - it's just not yet implemented

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.h
5 ↗(On Diff #42471)

Is it needed?

This revision is now accepted and ready to land.Jul 19 2024, 5:15 AM
native/cpp/CommonCpp/DatabaseManagers/entities/MessageSearchResult.h
29 ↗(On Diff #42471)

Newline

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.h
5 ↗(On Diff #42471)

Yes, in the cpp file

Don't forget to add to CMake!

Add CMake changes. Tested that android builds and no errors are thrown

This revision is now accepted and ready to land.Jul 23 2024, 1:22 AM
This revision was automatically updated to reflect the committed changes.