Paths

Table of Contentst

Differential D12851

[SQLite] implement tests for messages search
ClosedPublic
Actions

Authored by kamil on Jul 23 2024, 9:54 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

tomek
inka

Commits

rCOMM7085908cc6d2: [SQLite] implement tests for messages search

Summary

Testing searching logic - tests implemented by @inka.

Depends on D12850

Test Plan

Run tests

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 23 2024, 9:54 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 23 2024, 9:54 AM

kamil mentioned this in D12844: [SQLite] implement query for searching messages.Jul 23 2024, 9:55 AM

kamil mentioned this in D12850: [SQLite] add Emscripten bindings for message search.

rebase

kamil added a child revision: D12852: [web] introduce message searching to shared worker.Jul 23 2024, 10:05 AM

Harbormaster failed remote builds in B30594: Diff 42668!Jul 23 2024, 10:22 AM

Harbormaster completed remote builds in B30596: Diff 42670.Jul 23 2024, 10:34 AM

kamil published this revision for review.Jul 23 2024, 12:03 PM

We can consider one more thing: sorting the returned messages.

web/shared-worker/queries/message-search.test.js
139–146	Shouldn't this contain `targetMessageID`?
143	Can we use constants from `messageTypes`?
152	Can we validate more than just the ID? Like we do in other tests.
210
232

inka accepted this revision.Jul 23 2024, 1:44 PM

inka added inline comments.

web/shared-worker/queries/message-search.test.js
155	Can we change the text to reflect that the timestamp can be equal? For example "should return only messages with time equal or smaller than timestampCursor"
168	Why is this a leave thread message?
277	This is the same test as `should prioritizes timestampCursor over messageIDCursor`, we can remove one of them

This revision is now accepted and ready to land.Jul 23 2024, 1:44 PM

address review

Harbormaster completed remote builds in B30615: Diff 42702.Jul 23 2024, 3:12 PM

Closed by commit rCOMM7085908cc6d2: [SQLite] implement tests for messages search. · Explain WhyJul 23 2024, 3:18 PM

This revision was automatically updated to reflect the committed changes.

kamil mentioned this in rCOMM3b9546b1e346: [SQLite] implement query for searching messages.

kamil mentioned this in rCOMMffb88c4a6c6d: [SQLite] add Emscripten bindings for message search.

kamil added a commit: rCOMM7085908cc6d2: [SQLite] implement tests for messages search.

Revision Contents
Changeset List

Path

Size

web/

shared-worker/

queries/

message-search.test.js

311 lines

Diff 42670

web/shared-worker/queries/message-search.test.js

Loading...