Details

Reviewers

tomek
kamil
marcin

Commits

rCOMMed2425b8704c: [lib][web] Add worker logic for adding search messages

Summary

issue: ENG-8645

Test Plan

Added an update_search_messages operation in processDBStoreOperations in redux-utils.js. Tested that updateMessageSearchIndex was run and no errors showed up in the web console and worker console

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jul 19 2024, 3:17 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2024, 3:17 AM

inka added a parent revision: D12796: [native] Add CommCoreModule code for inserting into the search table.Jul 19 2024, 3:17 AM

Harbormaster completed remote builds in B30507: Diff 42520.Jul 19 2024, 3:33 AM

inka requested review of this revision.Jul 19 2024, 3:33 AM

inka added inline comments.Jul 19 2024, 4:06 AM

lib/message-search-types.js
5 ↗	(On Diff #42520)	This should also be read-only

kamil accepted this revision.Jul 19 2024, 5:20 AM

kamil added inline comments.

lib/message-search-types.js
9 ↗	(On Diff #42520)	this one is not needed - we don't do any additional parsing, so you can use `MessageSearchStoreOperation` everywhere but if you want to keep it to make naming in `ClientDBStoreOperations` this is also fine