Page MenuHomePhabricator
Differential D12843

[SQLite] add method for message search to SQLiteQueryExecutor for both web and native
ClosedPublic
Actions

Authored by kamil on Jul 22 2024, 10:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 7:41 PM
Unknown Object (File)
Sun, Oct 20, 12:57 PM
Unknown Object (File)
Tue, Oct 15, 7:49 PM
Unknown Object (File)
Mon, Oct 14, 3:16 PM
Unknown Object (File)
Mon, Oct 14, 3:16 PM
Unknown Object (File)
Mon, Oct 14, 3:16 PM
Unknown Object (File)
Mon, Oct 14, 3:16 PM
Unknown Object (File)
Fri, Oct 11, 12:18 AM
View All 48 Files
Subscribers
ashoat
marcin

Details

Reviewers
tomek
inka
Commits
rCOMMb290620829de: [SQLite] add method for message search to SQLiteQueryExecutor for both web and…
Summary

Defining API, logic will be implemented in searchMessages in the next diff.

Depends on D12833

Test Plan

N/A, just defining method arguments and returned type

Diff Detail

Repository
rCOMM Comm
Branch
land-cpp-search
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 22 2024, 10:13 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 22 2024, 10:13 AM
kamil added a child revision: D12844: [SQLite] implement query for searching messages.Jul 22 2024, 10:15 AM
Harbormaster failed remote builds in B30572: Diff 42636!Jul 22 2024, 10:35 AM
kamil updated this revision to Diff 42665.Jul 23 2024, 2:50 AM

rebase

kamil edited parent revisions, added: D12794: [native] Add MessageSearchStoreOperations; removed: D12833: [lib][web][native] Create message search store ops.Jul 23 2024, 2:51 AM
Harbormaster completed remote builds in B30591: Diff 42665.Jul 23 2024, 3:07 AM
kamil edited the summary of this revision. (Show Details)Jul 23 2024, 3:24 AM
kamil added a parent revision: D12833: [lib][web][native] Create message search store ops.
kamil removed a parent revision: D12833: [lib][web][native] Create message search store ops.
kamil published this revision for review.Jul 23 2024, 5:03 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2559 ↗(On Diff #42665)

implemented in D12844

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h
206 ↗(On Diff #42665)

for the web we need MessageWithMedias, and for native MessageEntity - this can be avoided after ENG-5719

tomek accepted this revision.Jul 23 2024, 6:10 AM
tomek added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2625 ↗(On Diff #42665)
2628 ↗(On Diff #42665)

Why do we move only the first item?

This revision is now accepted and ready to land.Jul 23 2024, 6:10 AM
inka accepted this revision.Jul 23 2024, 6:14 AM
marcin added a subscriber: marcin.Jul 23 2024, 7:15 AM
marcin added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2628 ↗(On Diff #42665)

The type of messageWithMedia.first is Message. The Message type has unique_ptr fields. Therefore it doesn't have copy constructor so it must be moved when passing to function.

kamil updated this revision to Diff 42698.Jul 23 2024, 7:16 AM
kamil added a parent revision: D12833: [lib][web][native] Create message search store ops.

rename

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2628 ↗(On Diff #42665)

Thanks!

kamil removed a parent revision: D12833: [lib][web][native] Create message search store ops.Jul 23 2024, 7:16 AM
Harbormaster completed remote builds in B30611: Diff 42698.Jul 23 2024, 7:32 AM
Closed by commit rCOMMb290620829de: [SQLite] add method for message search to SQLiteQueryExecutor for both web and… (authored by kamil). · Explain WhyJul 23 2024, 8:18 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMb290620829de: [SQLite] add method for message search to SQLiteQueryExecutor for both web and….

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
10 lines
10 lines
26 lines
web/
shared-worker/
_generated/

Diff 42698

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...