Depends on D13097
Details
Details
tested later in stack by successfully setting avatar from farcaster
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/utils/fc-cache.js | ||
|---|---|---|
| 144 | wasn't sure about this line | |
| lib/utils/fc-cache.js | ||
|---|---|---|
| 144 | JavaScript is weird... this condition will let null through because typeof null === 'object' To be fully consistent with the prior implementation, you should add || farcasterUser === null here (although not clear how important that is) | |
| lib/utils/fc-cache.js | ||
|---|---|---|
| 144 | Actually I'd just add || !farcasterUser rather than || farcasterUser === null | |