[native] Add possibility to display nux tip above an item
ClosedPublic
Actions

Authored by inka on Aug 13 2024, 9:27 AM.

Details

Reviewers

tomek
will

Commits

rCOMMeafdf064867d: [native] Add possibility to display nux tip above an item

Summary

issue: ENG-9039
I initially removed this logic during my refactor, but @ashoat requested adding it back in D12981

Test Plan

Rendered a tip with both above and below. Checked that the triangle is in the correct place, and the animation expands in the right direction

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Aug 13 2024, 9:27 AM

inka added a parent revision: D13071: [native] Refactor nux tips overlay to reanimated 2.Aug 13 2024, 9:27 AM

inka mentioned this in D12981: [native] Move tipContainerOpacity, tipVerticalBelow, tipHeight, margin.Aug 13 2024, 9:30 AM

Harbormaster completed remote builds in B31081: Diff 43367.Aug 13 2024, 9:44 AM

inka requested review of this revision.Aug 13 2024, 9:44 AM

inka added a child revision: D13077: [native] Add mappaing from nux tips to button onPress params.Aug 14 2024, 3:51 AM

Thanks for doing this!

native/tooltip/nux-tips-overlay.react.js
206 ↗	(On Diff #43367)	Why two statements on one line?

tomek accepted this revision.Aug 14 2024, 6:46 AM

tomek added inline comments.

native/tooltip/nux-tips-overlay.react.js
283 ↗	(On Diff #43367)	Why wasn't it included in the deps?

This revision is now accepted and ready to land.Aug 14 2024, 6:46 AM

inka mentioned this in D13069: [native] Extract normal style from animated style.Aug 19 2024, 7:31 AM

inka mentioned this in D13071: [native] Refactor nux tips overlay to reanimated 2.Aug 19 2024, 8:21 AM

inka added inline comments.Aug 19 2024, 8:24 AM

native/tooltip/nux-tips-overlay.react.js
206 ↗	(On Diff #43367)	I don't know what happened here. I'll fix this
283 ↗	(On Diff #43367)	Before it was outside of the component

Address review + fix translation y value (request from D13071)

Harbormaster completed remote builds in B31148: Diff 43462.Aug 19 2024, 8:48 AM

Closed by commit rCOMMeafdf064867d: [native] Add possibility to display nux tip above an item (authored by inka). · Explain WhyAug 20 2024, 2:00 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMeafdf064867d: [native] Add possibility to display nux tip above an item.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

nux-tips-overlay.react.js

81 lines

Diff 43462

View Options

native/tooltip/nux-tips-overlay.react.js

[native] Add possibility to display nux tip above an itemClosedPublicActions