Page MenuHomePhabricator
Differential D13127

[native] Update styling
ClosedPublic
Actions

Authored by inka on Aug 21 2024, 12:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 11:36 AM
Unknown Object (File)
Thu, Nov 21, 11:05 PM
Unknown Object (File)
Wed, Nov 13, 8:34 PM
Unknown Object (File)
Wed, Nov 13, 12:08 AM
Unknown Object (File)
Tue, Nov 12, 4:28 PM
Unknown Object (File)
Sun, Nov 10, 12:27 AM
Unknown Object (File)
Sat, Nov 9, 10:44 PM
Unknown Object (File)
Sat, Nov 9, 10:04 AM
View All 55 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMM68a1821a4d99: [native] Update styling
Summary

issue: ENG-9058

Test Plan

Please see the screenshots:

noFID.png (2×1 px, 318 KB)

Untitled.png (2×1 px, 328 KB)

drawerTip.png (2×1 px, 340 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Aug 21 2024, 12:23 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 21 2024, 12:23 AM
inka edited the test plan for this revision. (Show Details)Aug 21 2024, 12:23 AM
inka attached a referenced file: F2505648: noFID.png. (Show Details)
inka attached a referenced file: F2505647: Untitled.png. (Show Details)
inka attached a referenced file: F2505646: drawerTip.png. (Show Details)
inka added a parent revision: D13120: [native] Make it impossible to skip tips.
Harbormaster completed remote builds in B31189: Diff 43533.Aug 21 2024, 12:40 AM
inka requested review of this revision.Aug 21 2024, 12:40 AM
tomek accepted this revision.Aug 21 2024, 2:56 AM
tomek added inline comments.
native/tooltip/nux-tips-overlay.react.js
423 ↗(On Diff #43533)

Isn't it the default?

This revision is now accepted and ready to land.Aug 21 2024, 2:56 AM
inka updated this revision to Diff 43601.Aug 23 2024, 4:44 AM

Remove unnecessary code

Harbormaster completed remote builds in B31228: Diff 43601.Aug 23 2024, 5:01 AM
inka added a child revision: D13136: [native] Fix blinking overlay background.Aug 23 2024, 5:09 AM
Closed by commit rCOMM68a1821a4d99: [native] Update styling (authored by inka). · Explain WhyAug 29 2024, 6:43 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM68a1821a4d99: [native] Update styling.

Revision Contents
Changeset List

PathSize
native/
tooltip/
47 lines

Diff 43601

View Options

native/tooltip/nux-tips-overlay.react.js

Loading...