Paths

Table of Contentst

[lib] add `outboundP2PMessageIDs` to `LocalMessageInfo` to track progress
ClosedPublic
Actions

Authored by kamil on Aug 23 2024, 5:34 AM.

Details

Reviewers

tomek
inka

Commits

rCOMM56c71f48edcf: [lib] add `outboundP2PMessageIDs` to `LocalMessageInfo` to track progress

Summary

ENG-8423.

We decided to use the existing store for local messages for two reasons, to avoid adding a new store, and because in components, LocalMessageInfo is easily accessible (I think it saves us at least a couple of days of work).

Additionally LocalMessageInfo seems like a reasonable place to put this data.

All fields in LocalMessageInfo are optional, which means this does not require a migration.

Depends on D13152

Test Plan

Make sure outboundP2PMessageIDs are persisted & read on app start.

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 23 2024, 5:34 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 23 2024, 5:34 AM

kamil added a child revision: D13154: [lib] start tracking progress of DM messages on `processDMOpsActionType` action.Aug 23 2024, 5:38 AM

Harbormaster completed remote builds in B31237: Diff 43610.Aug 23 2024, 5:50 AM

kamil published this revision for review.Aug 23 2024, 7:25 AM

tomek accepted this revision.Aug 26 2024, 3:56 AM

tomek added inline comments.

lib/reducers/message-reducer.js
1664–1675 ↗	(On Diff #43610)	It is a bit hacky. We should at least generate a DB op to update the state.

This revision is now accepted and ready to land.Aug 26 2024, 3:56 AM

generate DB op

Harbormaster completed remote builds in B31261: Diff 43636.Aug 26 2024, 6:57 AM

kamil added a child revision: D13169: [lib] add `supportsAutoRetry` to `DMOperationSpec`.Aug 26 2024, 7:03 AM

kamil removed a child revision: D13154: [lib] start tracking progress of DM messages on `processDMOpsActionType` action.Aug 26 2024, 7:09 AM

Closed by commit rCOMM56c71f48edcf: [lib] add `outboundP2PMessageIDs` to `LocalMessageInfo` to track progress (authored by kamil). · Explain WhyAug 26 2024, 9:05 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM56c71f48edcf: [lib] add `outboundP2PMessageIDs` to `LocalMessageInfo` to track progress.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

47 lines

types/

message-types.js

4 lines

Diff 43651

View Options

lib/reducers/message-reducer.js