Differential D13175

[native] Add renderTabBarItem to MaterialTopTabBarProps
ClosedPublic
Actions

Authored by inka on Tue, Aug 27, 5:50 AM.

Tags

None

Referenced Files

	F2769155: D13175.id43745.diff
	Thu, Sep 19, 6:22 PM

	F2767506: D13175.diff
	Thu, Sep 19, 4:23 PM

	Unknown Object (File)
	Tue, Sep 17, 11:16 AM

	Unknown Object (File)
	Mon, Sep 16, 2:39 AM

	Unknown Object (File)
	Mon, Sep 16, 12:19 AM

	Unknown Object (File)
	Mon, Sep 16, 12:07 AM

	Unknown Object (File)
	Sun, Sep 15, 6:39 PM

	Unknown Object (File)
	Fri, Sep 13, 6:18 PM

View All 39 Files

Subscribers

Details

Reviewers

tomek
will

Commits

rCOMM8c422d195bc7: [native] Add renderTabBarItem to MaterialTopTabBarProps

Summary

issue: ENG-9041

Test Plan

flow

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Tue, Aug 27, 5:50 AM

Herald added a subscriber: ashoat. · View Herald TranscriptTue, Aug 27, 5:50 AM

inka added a child revision: D13082: [native] Create custom top tabs component.Tue, Aug 27, 5:56 AM

Harbormaster completed remote builds in B31285: Diff 43677.Tue, Aug 27, 6:08 AM

inka requested review of this revision.Tue, Aug 27, 6:08 AM

inka added a child revision: D13176: [native] Fix light mode highlighting.Tue, Aug 27, 6:37 AM

tomek accepted this revision.Tue, Aug 27, 7:31 AM

This revision is now accepted and ready to land.Tue, Aug 27, 7:31 AM

inka removed a child revision: D13176: [native] Fix light mode highlighting.Tue, Aug 27, 7:39 AM

Update renderTabBarItem type to use spread

Harbormaster completed remote builds in B31295: Diff 43696.Tue, Aug 27, 9:19 AM

Update TabBarItemProps

Harbormaster completed remote builds in B31335: Diff 43745.Wed, Aug 28, 7:02 AM

Closed by commit rCOMM8c422d195bc7: [native] Add renderTabBarItem to MaterialTopTabBarProps (authored by inka). · Explain WhyThu, Aug 29, 3:18 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM8c422d195bc7: [native] Add renderTabBarItem to MaterialTopTabBarProps.

ashoat mentioned this in D13263: [native] Fix up issues from D13175.Fri, Sep 6, 12:06 PM

Unfortunately lots of issues were landed here. I created D13263 as a follow-up, but in the future I'm hoping that diff authors don't put up diffs with these issues, and reviewers don't accept diffs with these issues

ashoat mentioned this in rCOMM5e6732ede2db: [native] Fix up issues from D13175.Mon, Sep 9, 5:47 AM

Revision Contents
Changeset List

Path

Size

native/

flow-typed/

npm/

@react-navigation/

59 lines

material-top-tabs_v6.x.x.js

3 lines

Diff 43677

native/flow-typed/npm/@react-navigation/core_v6.x.x.js

Loading...

native/flow-typed/npm/@react-navigation/material-top-tabs_v6.x.x.js

Loading...