Page MenuHomePhabricator
Differential D13175

[native] Add renderTabBarItem to MaterialTopTabBarProps
ClosedPublic
Actions

Authored by inka on Aug 27 2024, 5:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 7 2025, 6:58 AM
Unknown Object (File)
Mar 6 2025, 4:53 AM
Unknown Object (File)
Feb 19 2025, 1:13 PM
Unknown Object (File)
Feb 19 2025, 9:35 AM
Unknown Object (File)
Feb 19 2025, 8:45 AM
Unknown Object (File)
Feb 17 2025, 11:30 PM
Unknown Object (File)
Feb 17 2025, 11:30 PM
Unknown Object (File)
Feb 17 2025, 11:30 PM
View All 93 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMM8c422d195bc7: [native] Add renderTabBarItem to MaterialTopTabBarProps
Summary

issue: ENG-9041

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Aug 27 2024, 5:50 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 27 2024, 5:50 AM
inka added a child revision: D13082: [native] Create custom top tabs component.Aug 27 2024, 5:56 AM
Harbormaster completed remote builds in B31285: Diff 43677.Aug 27 2024, 6:08 AM
inka requested review of this revision.Aug 27 2024, 6:08 AM
inka added a child revision: D13176: [native] Fix light mode highlighting.Aug 27 2024, 6:37 AM
tomek accepted this revision.Aug 27 2024, 7:31 AM
This revision is now accepted and ready to land.Aug 27 2024, 7:31 AM
inka removed a child revision: D13176: [native] Fix light mode highlighting.Aug 27 2024, 7:39 AM
inka updated this revision to Diff 43696.Aug 27 2024, 8:43 AM

Update renderTabBarItem type to use spread

Harbormaster completed remote builds in B31295: Diff 43696.Aug 27 2024, 9:19 AM
inka updated this revision to Diff 43745.Aug 28 2024, 6:40 AM

Update TabBarItemProps

Harbormaster completed remote builds in B31335: Diff 43745.Aug 28 2024, 7:02 AM
Closed by commit rCOMM8c422d195bc7: [native] Add renderTabBarItem to MaterialTopTabBarProps (authored by inka). · Explain WhyAug 29 2024, 3:18 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM8c422d195bc7: [native] Add renderTabBarItem to MaterialTopTabBarProps.
ashoat mentioned this in D13263: [native] Fix up issues from D13175.Sep 6 2024, 12:06 PM
ashoat added a comment.Sep 6 2024, 12:08 PM

Unfortunately lots of issues were landed here. I created D13263 as a follow-up, but in the future I'm hoping that diff authors don't put up diffs with these issues, and reviewers don't accept diffs with these issues

ashoat mentioned this in rCOMM5e6732ede2db: [native] Fix up issues from D13175.Sep 9 2024, 5:47 AM

Revision Contents
Changeset List

PathSize
native/
flow-typed/
npm/
@react-navigation/
60 lines
3 lines

Diff 43745

View Options

native/flow-typed/npm/@react-navigation/core_v6.x.x.js

use lazy_static::lazy_static; use lazy_static::lazy_static;
use std::sync::Arc; use std::sync::Arc;
use tokio::runtime::{Builder, Runtime}; use tokio::runtime::{Builder, Runtime};
use tonic::{transport::Channel, Status}; use tonic::{transport::Channel, Status};
use tracing::instrument; use tracing::instrument;
mod crypto_tools;
mod identity_client; mod identity_client;
mod opaque; mod opaque;
mod identity { mod identity {
tonic::include_proto!("identity"); tonic::include_proto!("identity");
} }
use crypto_tools::generate_device_id;
use identity::identity_service_client::IdentityServiceClient; use identity::identity_service_client::IdentityServiceClient;
use identity_client::{ use identity_client::{
get_user_id, login_user_pake, login_user_wallet, register_user, get_user_id, login_user_pake, login_user_wallet, register_user,
verify_user_token, verify_user_token,
}; };
const IDENTITY_SERVICE_SOCKET_ADDR: &str = "https://[::1]:50051"; const IDENTITY_SERVICE_SOCKET_ADDR: &str = "https://[::1]:50051";
lazy_static! { lazy_static! {
pub static ref RUNTIME: Arc<Runtime> = Arc::new( pub static ref RUNTIME: Arc<Runtime> = Arc::new(
Builder::new_multi_thread() Builder::new_multi_thread()
.worker_threads(1) .worker_threads(1)
.max_blocking_threads(1) .max_blocking_threads(1)
.enable_all() .enable_all()
.build() .build()
.unwrap() .unwrap()
); );
} }
#[cxx::bridge] #[cxx::bridge]
mod ffi { mod ffi {
enum DeviceType {
KEYSERVER,
WEB,
MOBILE,
}
extern "Rust" { extern "Rust" {
// Identity Service Client
type Client; type Client;
fn initialize_client() -> Box<Client>; fn initialize_client() -> Box<Client>;
fn get_user_id_blocking( fn get_user_id_blocking(
client: Box<Client>, client: Box<Client>,
auth_type: i32, auth_type: i32,
user_info: String, user_info: String,
) -> Result<String>; ) -> Result<String>;
fn verify_user_token_blocking( fn verify_user_token_blocking(
Show All 20 Lines extern "Rust" {
fn login_user_wallet_blocking( fn login_user_wallet_blocking(
client: Box<Client>, client: Box<Client>,
user_id: String, user_id: String,
device_id: String, device_id: String,
siwe_message: String, siwe_message: String,
siwe_signature: Vec<u8>, siwe_signature: Vec<u8>,
user_public_key: String, user_public_key: String,
) -> Result<String>; ) -> Result<String>;
// Crypto Tools
fn generate_device_id(device_type: DeviceType) -> Result<String>;
} }
} }
#[derive(Debug)] #[derive(Debug)]
pub struct Client { pub struct Client {
identity_client: IdentityServiceClient<Channel>, identity_client: IdentityServiceClient<Channel>,
} }
▲ Show 20 Lines • Show All 81 Lines • Show Last 20 Lines
View Options

native/flow-typed/npm/@react-navigation/material-top-tabs_v6.x.x.js

use lazy_static::lazy_static; use lazy_static::lazy_static;
use std::sync::Arc; use std::sync::Arc;
use tokio::runtime::{Builder, Runtime}; use tokio::runtime::{Builder, Runtime};
use tonic::{transport::Channel, Status}; use tonic::{transport::Channel, Status};
use tracing::instrument; use tracing::instrument;
mod crypto_tools;
mod identity_client; mod identity_client;
mod opaque; mod opaque;
mod identity { mod identity {
tonic::include_proto!("identity"); tonic::include_proto!("identity");
} }
use crypto_tools::generate_device_id;
use identity::identity_service_client::IdentityServiceClient; use identity::identity_service_client::IdentityServiceClient;
use identity_client::{ use identity_client::{
get_user_id, login_user_pake, login_user_wallet, register_user, get_user_id, login_user_pake, login_user_wallet, register_user,
verify_user_token, verify_user_token,
}; };
const IDENTITY_SERVICE_SOCKET_ADDR: &str = "https://[::1]:50051"; const IDENTITY_SERVICE_SOCKET_ADDR: &str = "https://[::1]:50051";
lazy_static! { lazy_static! {
pub static ref RUNTIME: Arc<Runtime> = Arc::new( pub static ref RUNTIME: Arc<Runtime> = Arc::new(
Builder::new_multi_thread() Builder::new_multi_thread()
.worker_threads(1) .worker_threads(1)
.max_blocking_threads(1) .max_blocking_threads(1)
.enable_all() .enable_all()
.build() .build()
.unwrap() .unwrap()
); );
} }
#[cxx::bridge] #[cxx::bridge]
mod ffi { mod ffi {
enum DeviceType {
KEYSERVER,
WEB,
MOBILE,
}
extern "Rust" { extern "Rust" {
// Identity Service Client
type Client; type Client;
fn initialize_client() -> Box<Client>; fn initialize_client() -> Box<Client>;
fn get_user_id_blocking( fn get_user_id_blocking(
client: Box<Client>, client: Box<Client>,
auth_type: i32, auth_type: i32,
user_info: String, user_info: String,
) -> Result<String>; ) -> Result<String>;
fn verify_user_token_blocking( fn verify_user_token_blocking(
Show All 20 Lines extern "Rust" {
fn login_user_wallet_blocking( fn login_user_wallet_blocking(
client: Box<Client>, client: Box<Client>,
user_id: String, user_id: String,
device_id: String, device_id: String,
siwe_message: String, siwe_message: String,
siwe_signature: Vec<u8>, siwe_signature: Vec<u8>,
user_public_key: String, user_public_key: String,
) -> Result<String>; ) -> Result<String>;
// Crypto Tools
fn generate_device_id(device_type: DeviceType) -> Result<String>;
} }
} }
#[derive(Debug)] #[derive(Debug)]
pub struct Client { pub struct Client {
identity_client: IdentityServiceClient<Channel>, identity_client: IdentityServiceClient<Channel>,
} }
▲ Show 20 Lines • Show All 81 Lines • Show Last 20 Lines