Differential D13175

[native] Add renderTabBarItem to MaterialTopTabBarProps
ClosedPublic
Actions

Authored by inka on Aug 27 2024, 5:50 AM.

Tags

None

Referenced Files

	F3503728: D13175.id43745.diff
	Fri, Dec 20, 6:17 AM

	F3503719: D13175.id43792.diff
	Fri, Dec 20, 6:14 AM

	F3499929: D13175.diff
	Fri, Dec 20, 12:38 AM

	Unknown Object (File)
	Wed, Dec 18, 5:03 PM

	Unknown Object (File)
	Wed, Dec 18, 5:03 PM

	Unknown Object (File)
	Wed, Dec 18, 5:03 PM

	Unknown Object (File)
	Wed, Dec 18, 5:03 PM

	Unknown Object (File)
	Wed, Dec 18, 5:03 PM

View All 75 Files

Subscribers

Details

Reviewers

tomek
will

Commits

rCOMM8c422d195bc7: [native] Add renderTabBarItem to MaterialTopTabBarProps

Summary

issue: ENG-9041

Test Plan

flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Aug 27 2024, 5:50 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 27 2024, 5:50 AM

inka added a child revision: D13082: [native] Create custom top tabs component.Aug 27 2024, 5:56 AM

Harbormaster completed remote builds in B31285: Diff 43677.Aug 27 2024, 6:08 AM

inka requested review of this revision.Aug 27 2024, 6:08 AM

inka added a child revision: D13176: [native] Fix light mode highlighting.Aug 27 2024, 6:37 AM

tomek accepted this revision.Aug 27 2024, 7:31 AM

This revision is now accepted and ready to land.Aug 27 2024, 7:31 AM

inka removed a child revision: D13176: [native] Fix light mode highlighting.Aug 27 2024, 7:39 AM

Update renderTabBarItem type to use spread

Harbormaster completed remote builds in B31295: Diff 43696.Aug 27 2024, 9:19 AM

Update TabBarItemProps

Harbormaster completed remote builds in B31335: Diff 43745.Aug 28 2024, 7:02 AM

Closed by commit rCOMM8c422d195bc7: [native] Add renderTabBarItem to MaterialTopTabBarProps (authored by inka). · Explain WhyAug 29 2024, 3:18 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM8c422d195bc7: [native] Add renderTabBarItem to MaterialTopTabBarProps.

ashoat mentioned this in D13263: [native] Fix up issues from D13175.Sep 6 2024, 12:06 PM

Unfortunately lots of issues were landed here. I created D13263 as a follow-up, but in the future I'm hoping that diff authors don't put up diffs with these issues, and reviewers don't accept diffs with these issues

ashoat mentioned this in rCOMM5e6732ede2db: [native] Fix up issues from D13175.Sep 9 2024, 5:47 AM

Revision Contents
Changeset List

Path

Size

native/

flow-typed/

npm/

@react-navigation/

60 lines

material-top-tabs_v6.x.x.js

3 lines

Diff 43792

native/flow-typed/npm/@react-navigation/core_v6.x.x.js

Loading...

native/flow-typed/npm/@react-navigation/material-top-tabs_v6.x.x.js

Loading...