Page MenuHomePhabricator
Differential D13206

[native] Hide nux behind a flag
ClosedPublic
Actions

Authored by inka on Aug 29 2024, 3:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 8:08 PM
Unknown Object (File)
Feb 17 2025, 11:30 PM
Unknown Object (File)
Feb 17 2025, 11:30 PM
Unknown Object (File)
Feb 17 2025, 11:30 PM
Unknown Object (File)
Feb 17 2025, 11:30 PM
Unknown Object (File)
Feb 17 2025, 1:54 AM
Unknown Object (File)
Jan 15 2025, 12:03 PM
Unknown Object (File)
Jan 1 2025, 1:30 AM
View All 64 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMMb84bcdfa2086: [native] Hide nux behind a flag
Summary

issue: ENG-9107

Test Plan

Tested that nux tips are not show after installing the app

Diff Detail

Repository
rCOMM Comm
Branch
inka/nux
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Aug 29 2024, 3:24 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 29 2024, 3:24 AM
inka added a parent revision: D13194: [native] Simplify nux tips props design.Aug 29 2024, 3:26 AM
Harbormaster completed remote builds in B31364: Diff 43795.Aug 29 2024, 3:41 AM
inka requested review of this revision.Aug 29 2024, 3:41 AM
tomek accepted this revision.Aug 29 2024, 4:44 AM

We probably should create a task tracking removing this flag.

This revision is now accepted and ready to land.Aug 29 2024, 4:44 AM
inka added a comment.Aug 29 2024, 6:39 AM
In D13206#372556, @tomek wrote:

We probably should create a task tracking removing this flag.

ENG-9111

Closed by commit rCOMMb84bcdfa2086: [native] Hide nux behind a flag (authored by inka). · Explain WhyAug 29 2024, 6:44 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMb84bcdfa2086: [native] Hide nux behind a flag.

Revision Contents
Changeset List

PathSize
native/
components/
4 lines

Diff 43795

View Options

native/components/nux-handler.react.js

// Top-level build file where you can add configuration options common to all sub-projects/modules. // Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript { buildscript {
ext { ext {
buildToolsVersion = "31.0.0" buildToolsVersion = "31.0.0"
minSdkVersion = 21 minSdkVersion = 21
compileSdkVersion = 31 compileSdkVersion = 31
targetSdkVersion = 31 targetSdkVersion = 31
// We can't use NDK 24 yet because of Folly build issues if (System.properties['os.arch'] == "aarch64") {
// https://linear.app/comm/issue/ENG-2169/update-folly-on-android // For M1 Users we need to use the NDK 24 which added support for aarch64
//if (System.properties['os.arch'] == "aarch64") { ndkVersion = "24.0.8215888"
// // For M1 Users we need to use the NDK 24 which added support for aarch64 } else {
// ndkVersion = "24.0.8215888" // Otherwise we default to the side-by-side NDK version from AGP.
//} else {
// // Otherwise we default to the side-by-side NDK version from AGP.
// ndkVersion = "21.4.7075529"
//}
ndkVersion = "21.4.7075529" ndkVersion = "21.4.7075529"
} }
}
repositories { repositories {
google() google()
mavenCentral() mavenCentral()
} }
dependencies { dependencies {
classpath("com.android.tools.build:gradle:7.2.1") classpath("com.android.tools.build:gradle:7.2.1")
classpath("com.facebook.react:react-native-gradle-plugin") classpath("com.facebook.react:react-native-gradle-plugin")
classpath("de.undercouch:gradle-download-task:5.0.1") classpath("de.undercouch:gradle-download-task:5.0.1")
Show All 35 Lines