Page MenuHomePhabricator

[identity] Remove blob holders on logout and account deletion
ClosedPublic

Authored by bartek on Oct 9 2024, 1:45 AM.
Tags
None
Referenced Files
F3337571: D13652.id45002.diff
Thu, Nov 21, 4:49 PM
F3335903: D13652.diff
Thu, Nov 21, 12:15 PM
Unknown Object (File)
Wed, Nov 20, 9:30 AM
Unknown Object (File)
Wed, Nov 20, 9:30 AM
Unknown Object (File)
Mon, Nov 11, 6:51 AM
Unknown Object (File)
Sat, Nov 9, 12:59 AM
Unknown Object (File)
Sat, Nov 9, 12:58 AM
Unknown Object (File)
Fri, Nov 1, 4:06 AM
Subscribers

Details

Summary

Final diff for ENG-9368.

  • Besides Tunnelbroker and Backup data, blob holders are also removed
  • Some renames

Depends on D13651

Test Plan

Mocked this by creating a device by Commtest, manually added some holders prefixed by its device ID, then logging it out (also with commtest).
Checked Identity logs and DDB by querying for indexed_tag=deviceID. Verified that holders were gone.

Final testing will be done on staging:

  • Log in a device, jot down its device ID, start a DM thread, set avatar to image, then reset back to emoji.
  • Simulate blob service connection error - change blob URL client to fake, or comment-out the call and return failure.
  • Log out the device.
  • Verify Identity logs and DDB by querying for indexed_tag=deviceID. Holders should be gone.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage