Paths

Table of Contentst

Differential D13807

[backup-service] use `username` instead of `userID` when downloading backup
ClosedPublic
Actions

Authored by kamil on Oct 29 2024, 9:07 AM.

Tags

None

Referenced Files

	F3654067: D13807.id45454.diff
	Sun, Jan 5, 9:57 AM

	F3649052: D13807.diff
	Sun, Jan 5, 4:19 AM

	Unknown Object (File)
	Sat, Dec 21, 11:34 PM

	Unknown Object (File)
	Sat, Dec 21, 11:34 PM

	Unknown Object (File)
	Sat, Dec 21, 11:34 PM

	Unknown Object (File)
	Sat, Dec 21, 11:34 PM

	Unknown Object (File)
	Sat, Dec 21, 11:34 PM

	Unknown Object (File)
	Sat, Dec 21, 11:34 PM

View All 65 Files

Subscribers

Details

Reviewers

varun
bartek

Commits

rCOMMf10da684e155: [backup-service] use `username` instead of `userID` when downloading backup

Summary

Updating places where we had hardcoded userID

Depends on D13817

Test Plan

run commtest

Diff Detail

Repository

Branch

backup-work

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Oct 29 2024, 9:07 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 29 2024, 9:07 AM

kamil added a child revision: D13808: [backup-service][backup-client] rename `username` -> `user_identifier`.Oct 29 2024, 9:19 AM

Harbormaster failed remote builds in B32406: Diff 45428!Oct 29 2024, 9:44 AM

CI

Harbormaster failed remote builds in B32426: Diff 45453!Oct 30 2024, 2:52 AM

CI v2

Harbormaster completed remote builds in B32427: Diff 45454.Oct 30 2024, 3:16 AM

rebase

kamil edited the summary of this revision. (Show Details)Oct 30 2024, 3:30 AM

kamil removed a child revision: D13817: [docker-compose] configure Identity endpoint for backup in commtest.

kamil edited parent revisions, added: D13817: [docker-compose] configure Identity endpoint for backup in commtest; removed: D13806: [backup-service] implement calling `FindUserID` RPC from Backup.

kamil edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B32429: Diff 45456.Oct 30 2024, 3:47 AM

kamil published this revision for review.Oct 30 2024, 9:28 AM

varun accepted this revision.Nov 1 2024, 2:14 PM

varun added inline comments.

services/commtest/tests/backup_integration_test.rs
78 ↗	(On Diff #45456)
80 ↗	(On Diff #45456)
83 ↗	(On Diff #45456)
services/commtest/tests/backup_performance_test.rs
91 ↗	(On Diff #45456)	just curious, what do we use this descriptor for?

This revision is now accepted and ready to land.Nov 1 2024, 2:14 PM

bartek accepted this revision.Nov 4 2024, 4:59 AM

bartek added inline comments.

services/commtest/tests/backup_performance_test.rs
91 ↗	(On Diff #45456)	we use it to determine what kind of backup we want to perform action on. It can be either: Latest backup for given user Backup with specific ID

fix typo

Harbormaster completed remote builds in B32535: Diff 45603.Nov 5 2024, 4:34 AM

Closed by commit rCOMMf10da684e155: [backup-service] use `username` instead of `userID` when downloading backup (authored by kamil). · Explain WhyNov 7 2024, 4:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMf10da684e155: [backup-service] use `username` instead of `userID` when downloading backup.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

http/

handlers/

7 lines

commtest/

tests/

backup_integration_test.rs

24 lines

backup_performance_test.rs

19 lines

Diff 45428

services/backup/src/http/handlers/backup.rs

Loading...

services/commtest/tests/backup_integration_test.rs

Loading...

services/commtest/tests/backup_performance_test.rs

Loading...