Paths

Table of Contentst

Differential D13807

[backup-service] use `username` instead of `userID` when downloading backup
ClosedPublic
Actions

Authored by kamil on Tue, Oct 29, 9:07 AM.

Tags

None

Referenced Files

	F3331678: D13807.diff
	Wed, Nov 20, 9:02 PM

	F3325286: D13807.diff
	Wed, Nov 20, 5:47 AM

	Unknown Object (File)
	Sun, Nov 17, 10:34 AM

	Unknown Object (File)
	Sun, Nov 17, 3:40 AM

	Unknown Object (File)
	Sat, Nov 16, 6:23 PM

	Unknown Object (File)
	Sat, Nov 16, 2:33 AM

	Unknown Object (File)
	Thu, Nov 14, 6:06 PM

	Unknown Object (File)
	Tue, Nov 12, 4:39 PM

View All 40 Files

Subscribers

Details

Reviewers

varun
bartek

Commits

rCOMMf10da684e155: [backup-service] use `username` instead of `userID` when downloading backup

Summary

Updating places where we had hardcoded userID

Depends on D13817

Test Plan

run commtest

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Tue, Oct 29, 9:07 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Oct 29, 9:07 AM

kamil added a child revision: D13808: [backup-service][backup-client] rename `username` -> `user_identifier`.Tue, Oct 29, 9:19 AM

Harbormaster failed remote builds in B32406: Diff 45428!Tue, Oct 29, 9:44 AM

CI

Harbormaster failed remote builds in B32426: Diff 45453!Wed, Oct 30, 2:52 AM

CI v2

Harbormaster completed remote builds in B32427: Diff 45454.Wed, Oct 30, 3:16 AM

rebase

kamil edited the summary of this revision. (Show Details)Wed, Oct 30, 3:30 AM

kamil removed a child revision: D13817: [docker-compose] configure Identity endpoint for backup in commtest.

kamil edited parent revisions, added: D13817: [docker-compose] configure Identity endpoint for backup in commtest; removed: D13806: [backup-service] implement calling `FindUserID` RPC from Backup.

kamil edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B32429: Diff 45456.Wed, Oct 30, 3:47 AM

kamil published this revision for review.Wed, Oct 30, 9:28 AM

varun accepted this revision.Fri, Nov 1, 2:14 PM

varun added inline comments.

services/commtest/tests/backup_integration_test.rs
78 ↗	(On Diff #45456)
80 ↗	(On Diff #45456)
83 ↗	(On Diff #45456)
services/commtest/tests/backup_performance_test.rs
91 ↗	(On Diff #45456)	just curious, what do we use this descriptor for?

This revision is now accepted and ready to land.Fri, Nov 1, 2:14 PM

bartek accepted this revision.Mon, Nov 4, 4:59 AM

bartek added inline comments.

services/commtest/tests/backup_performance_test.rs
91 ↗	(On Diff #45456)	we use it to determine what kind of backup we want to perform action on. It can be either: Latest backup for given user Backup with specific ID

fix typo

Harbormaster completed remote builds in B32535: Diff 45603.Tue, Nov 5, 4:34 AM

Closed by commit rCOMMf10da684e155: [backup-service] use `username` instead of `userID` when downloading backup (authored by kamil). · Explain WhyThu, Nov 7, 4:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMf10da684e155: [backup-service] use `username` instead of `userID` when downloading backup.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

http/

handlers/

7 lines

commtest/

tests/

backup_integration_test.rs

24 lines

backup_performance_test.rs

19 lines

Diff 45664

services/backup/src/http/handlers/backup.rs

Loading...

services/commtest/tests/backup_integration_test.rs

Loading...

services/commtest/tests/backup_performance_test.rs

Loading...