Details
Details
run commtest
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- backup-work
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/native_rust_library/src/backup.rs | ||
|---|---|---|
| 328 | this is going to be updated later as part of Native changes for minimal version of backup | |
| native/native_rust_library/src/backup.rs | ||
|---|---|---|
| 334 ↗ | (On Diff #45457) | confused why we use user_id here |
| native/native_rust_library/src/backup.rs | ||
|---|---|---|
| 334 ↗ | (On Diff #45457) | We don't have a user_identifier (username/wallet) here. The initial version of the backup used user_id - and the point of this whole stack is to change this, this diff is only about renaming service and client prop. Later in the stack in D13837 I implemented code that uses user_identifier correctly, in D13849 I updated rest of the code to start using this and this particular method is removed. I know this is confusing, but there was not better option to slice it for diffs, I could either cause CI falling or submit one diff with squashed all commits form this stack. |