[lib] Inline createChatThreadItem
ClosedPublic
Actions

Authored by ashoat on Wed, Oct 30, 11:42 AM.

Tags

None

Referenced Files

	F3351573: D13824.diff
	Sat, Nov 23, 2:35 AM

	Unknown Object (File)
	Sun, Nov 17, 9:06 PM

	Unknown Object (File)
	Thu, Nov 14, 4:52 PM

	Unknown Object (File)
	Thu, Nov 14, 4:27 PM

	Unknown Object (File)
	Tue, Nov 12, 8:13 PM

	Unknown Object (File)
	Mon, Nov 11, 7:44 PM

	Unknown Object (File)
	Mon, Nov 11, 7:20 PM

	Unknown Object (File)
	Mon, Nov 11, 6:01 PM

View All 29 Files

Subscribers

None

Details

Reviewers

tomek

Commits

rCOMMfd009c90168e: [lib] Inline createChatThreadItem

Summary

Now that it's only called from one place, we can reduce the indirection by inlining it.

Depends on D13823

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Wed, Oct 30, 11:42 AM

ashoat added a child revision: D13825: [native] Handle rendering "No messages" inside MessagePreview.

Harbormaster completed remote builds in B32441: Diff 45474.Wed, Oct 30, 12:16 PM

ashoat requested review of this revision.Wed, Oct 30, 12:16 PM

tomek accepted this revision.Thu, Oct 31, 5:35 AM

This revision is now accepted and ready to land.Thu, Oct 31, 5:35 AM

Closed by commit rCOMMfd009c90168e: [lib] Inline createChatThreadItem (authored by ashoat). · Explain WhyThu, Oct 31, 11:38 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMfd009c90168e: [lib] Inline createChatThreadItem.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

chat-selectors.js

157 lines

Diff 45474

View Options

lib/selectors/chat-selectors.js

[lib] Inline createChatThreadItemClosedPublicActions