Page MenuHomePhabricator

[backup-service][commtest] implement integration tests for uploading User Keys and User Data separately
ClosedPublic

Authored by kamil on Tue, Nov 5, 9:12 AM.
Tags
None
Referenced Files
F3348541: D13879.id45636.diff
Fri, Nov 22, 3:06 PM
F3348538: D13879.id45614.diff
Fri, Nov 22, 3:05 PM
F3347062: D13879.id45654.diff
Fri, Nov 22, 10:57 AM
Unknown Object (File)
Wed, Nov 20, 4:54 PM
Unknown Object (File)
Mon, Nov 18, 5:19 PM
Unknown Object (File)
Sat, Nov 16, 7:50 PM
Unknown Object (File)
Sat, Nov 16, 2:44 PM
Unknown Object (File)
Sat, Nov 16, 2:44 AM
Subscribers

Details

Summary

Part of ENG-9673.

Tracked in ENG-9650.

I think I covered most of the cases, this is described in the code comments.

The endpoint to upload both User Keys and User Data at once is tested in backup_integration_test.

If anyone has any ideas about what test case can be added, I would be happy to do it.

Depends on D13878

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Branch
backup-work-6
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil added reviewers: tomek, angelika.

fix running tests at once

kamil published this revision for review.Wed, Nov 6, 5:08 AM

Adding more reviewers here - maybe there is more edge-cases that worth testing too

services/commtest/tests/backup_upload_test.rs
69–79 ↗(On Diff #45635)

we can additionally check here if new_backup_data could be downloaded but probably not worth it, as it's covered in the test below too

83–116 ↗(On Diff #45635)

Here, I additionally checked if holders on the Blob service are managed correctly

This revision is now accepted and ready to land.Wed, Nov 6, 9:41 PM