Page MenuHomePhabricator
Differential D13879

[backup-service][commtest] implement integration tests for uploading User Keys and User Data separately
ClosedPublic
Actions

Authored by kamil on Tue, Nov 5, 9:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 4:54 PM
Unknown Object (File)
Mon, Nov 18, 5:19 PM
Unknown Object (File)
Sat, Nov 16, 7:50 PM
Unknown Object (File)
Sat, Nov 16, 2:44 PM
Unknown Object (File)
Sat, Nov 16, 2:44 AM
Unknown Object (File)
Fri, Nov 15, 10:48 PM
Unknown Object (File)
Fri, Nov 15, 10:07 PM
Unknown Object (File)
Fri, Nov 15, 3:32 AM
View All 53 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
tomek
angelika
Commits
rCOMM82729d054cba: [backup-service][commtest] implement integration tests for uploading User Keys…
Summary

Part of ENG-9673.

Tracked in ENG-9650.

I think I covered most of the cases, this is described in the code comments.

The endpoint to upload both User Keys and User Data at once is tested in backup_integration_test.

If anyone has any ideas about what test case can be added, I would be happy to do it.

Depends on D13878

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Branch
backup-work-6
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Tue, Nov 5, 9:12 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Nov 5, 9:12 AM
kamil mentioned this in D13876: [backup-service] implement endpoint to upload User Keys.Tue, Nov 5, 9:16 AM
kamil mentioned this in D13877: [backup-service] implement endpoint to upload User Data.
kamil mentioned this in D13878: [backup-service] make `user_data` and `user_keys` optional in `BackupData`.
Harbormaster failed remote builds in B32546: Diff 45614!Tue, Nov 5, 9:36 AM
kamil updated this revision to Diff 45635.Wed, Nov 6, 3:34 AM

rebase

kamil mentioned this in D13875: [backup-service] make `user_data` optional in `BackupItem`.Wed, Nov 6, 3:34 AM
kamil edited the summary of this revision. (Show Details)Wed, Nov 6, 3:47 AM
kamil added reviewers: tomek, angelika.
Harbormaster failed remote builds in B32558: Diff 45635!Wed, Nov 6, 4:00 AM
kamil updated this revision to Diff 45636.Wed, Nov 6, 4:05 AM

fix running tests at once

kamil updated this revision to Diff 45638.Wed, Nov 6, 4:30 AM

fix conversion

Harbormaster failed remote builds in B32559: Diff 45636!Wed, Nov 6, 4:31 AM
Harbormaster completed remote builds in B32560: Diff 45638.Wed, Nov 6, 4:48 AM
kamil published this revision for review.Wed, Nov 6, 5:08 AM

Adding more reviewers here - maybe there is more edge-cases that worth testing too

services/commtest/tests/backup_upload_test.rs
69–79 ↗(On Diff #45635)

we can additionally check here if new_backup_data could be downloaded but probably not worth it, as it's covered in the test below too

83–116 ↗(On Diff #45635)

Here, I additionally checked if holders on the Blob service are managed correctly

bartek accepted this revision.Wed, Nov 6, 9:41 PM
This revision is now accepted and ready to land.Wed, Nov 6, 9:41 PM
kamil updated this revision to Diff 45654.Thu, Nov 7, 3:25 AM

rebase before landing

Harbormaster failed remote builds in B32567: Diff 45654!Thu, Nov 7, 3:31 AM
Harbormaster completed remote builds in B32567: Diff 45654.Thu, Nov 7, 4:03 AM
Closed by commit rCOMM82729d054cba: [backup-service][commtest] implement integration tests for uploading User Keys… (authored by kamil). · Explain WhyThu, Nov 7, 4:07 AM
This revision was automatically updated to reflect the committed changes.
kamil mentioned this in rCOMMe8f80a8bdb8c: [backup-service] make `user_data` optional in `BackupItem`.
kamil mentioned this in rCOMM3eeef1e77029: [backup-service] implement endpoint to upload User Keys.
kamil mentioned this in rCOMM556469ea7e45: [backup-service] implement endpoint to upload User Data.
kamil mentioned this in rCOMM8561f8e86b3e: [backup-service] make `user_data` and `user_keys` optional in `BackupData`.
kamil added a commit: rCOMM82729d054cba: [backup-service][commtest] implement integration tests for uploading User Keys….

Revision Contents
Changeset List

PathSize
services/
commtest/
src/
backup/
7 lines
tests/
2 lines
278 lines

Diff 45638

View Options

services/commtest/src/backup/backup_utils.rs

Loading...
View Options

services/commtest/tests/backup_performance_test.rs

Loading...
View Options

services/commtest/tests/backup_upload_test.rs

Loading...