Differential D13912

[lib] Extract getLastUpdatedTime to a separate file
ClosedPublic
Actions

Authored by ashoat on Tue, Nov 12, 12:40 PM.

Details

Reviewers

tomek

Commits

rCOMM084e0062ebd5: [lib] Extract getLastUpdatedTime to a separate file

Summary

This will make a following diff a little easier.

Note that this isn't a pure move; I've removed the isEmptyMediaMessage check, which will be reimplemented inside a message spec in the next diff.

Depends on D13911

Test Plan

Flow. Also tested in combination with the rest of the stack

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Tue, Nov 12, 12:40 PM

ashoat edited the summary of this revision. (Show Details)Tue, Nov 12, 12:40 PM

ashoat added inline comments.

lib/selectors/chat-selectors.js
106	Note that this isn't a pure move; I've removed the `isEmptyMediaMessage` check, which will be reimplemented inside a message spec in the next diff.

ashoat added a child revision: D13913: [lib] Introduce MessageSpec.getLastUpdatedTime.Tue, Nov 12, 12:41 PM

Harbormaster completed remote builds in B32623: Diff 45759.Tue, Nov 12, 1:07 PM

ashoat requested review of this revision.Tue, Nov 12, 1:07 PM

tomek accepted this revision.Wed, Nov 13, 3:38 AM

This revision is now accepted and ready to land.Wed, Nov 13, 3:38 AM

Closed by commit rCOMM084e0062ebd5: [lib] Extract getLastUpdatedTime to a separate file (authored by ashoat). · Explain WhyWed, Nov 13, 11:20 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM084e0062ebd5: [lib] Extract getLastUpdatedTime to a separate file.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

thread-time.js

25 lines

selectors/

chat-selectors.js

20 lines

Diff 45759

View Options

lib/hooks/thread-time.js