lib/shared/messages/add-members-message-spec.js
238 ↗	(On Diff #45779)	Don't bump thick thread timestamp for membership robotext Shouldn't the condition be inversed? When we return `null` here, the timestamp isn't bumped, so we should return `null` for thick threads. Is it correct?

This revision is now accepted and ready to land.Wed, Nov 13, 4:57 AM

ashoat added inline comments.Wed, Nov 13, 11:13 AM

lib/shared/messages/add-members-message-spec.js
238 ↗	(On Diff #45779)	Yes, you're absolutely right. I probably should've tested this better...

ashoat added inline comments.Wed, Nov 13, 11:15 AM

lib/shared/messages/add-members-message-spec.js
238 ↗	(On Diff #45779)	Wait no, this behavior is actually correct. We want to match behavior with `showInMessagePreview`, which hides for thin threads but shows for thick threads. Similarly, here we want to skip bumping for thin threads, but continue bumping for thick threads.

tomek added inline comments.Thu, Nov 14, 1:04 AM

lib/shared/messages/add-members-message-spec.js
238 ↗	(On Diff #45779)	Ok, that makes sense! But in that case, the diff's title should be updated.

ashoat retitled this revision from [lib] Don't bump thick thread timestamp for membership robotext to [lib] Don't bump thin thread timestamp for membership robotext.Thu, Nov 14, 4:53 AM

ashoat added inline comments.