Page MenuHomePhabricator

[native] Stop resetting ChatThreadList on navigation
ClosedPublic

Authored by ashoat on Wed, Dec 11, 3:52 PM.
Tags
None
Referenced Files
F3635246: D14144.id46396.diff
Fri, Jan 3, 11:28 AM
Unknown Object (File)
Thu, Jan 2, 2:43 AM
Unknown Object (File)
Mon, Dec 30, 1:40 AM
Unknown Object (File)
Thu, Dec 26, 5:50 AM
Unknown Object (File)
Thu, Dec 26, 3:26 AM
Unknown Object (File)
Wed, Dec 25, 9:53 PM
Unknown Object (File)
Wed, Dec 25, 4:16 PM
Unknown Object (File)
Tue, Dec 24, 8:40 AM
Subscribers
None

Details

Summary

Currently, if the user scrolls down to a chat and then opens it, and then goes back, the ChatThreadList will not appear the same as before, and their chat may not be visible.

I think this is confusing behavior in the first place. It gets especially bad when the ChatThreadList is reloading its order async.

Depends on D14143

Test Plan

I tested this task by playing around with the ChatThreadList on mobile while using a stopwatch to measure how long various operations took. I tested the updated code 3 times against both the most recent Testflight build as well as master. I found that performance was approximately the same as before. I tested scrolling down, selecting threads that were read, selecting threads that were unread, and search.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage