Page MenuHomePhabricator

[native] Stop resetting ChatThreadList on navigation
ClosedPublic

Authored by ashoat on Dec 11 2024, 3:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 28, 6:59 PM
Unknown Object (File)
Sat, Feb 22, 9:34 PM
Unknown Object (File)
Sat, Feb 22, 9:34 PM
Unknown Object (File)
Sat, Feb 22, 9:34 PM
Unknown Object (File)
Sat, Feb 22, 8:11 PM
Unknown Object (File)
Tue, Feb 18, 10:21 AM
Unknown Object (File)
Tue, Feb 18, 10:21 AM
Unknown Object (File)
Feb 3 2025, 3:28 PM
Subscribers
None

Details

Summary

Currently, if the user scrolls down to a chat and then opens it, and then goes back, the ChatThreadList will not appear the same as before, and their chat may not be visible.

I think this is confusing behavior in the first place. It gets especially bad when the ChatThreadList is reloading its order async.

Depends on D14143

Test Plan

I tested this task by playing around with the ChatThreadList on mobile while using a stopwatch to measure how long various operations took. I tested the updated code 3 times against both the most recent Testflight build as well as master. I found that performance was approximately the same as before. I tested scrolling down, selecting threads that were read, selecting threads that were unread, and search.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage