Differential D14468

[native] Add MediaModule expo module
ClosedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:30 AM.

Tags

None

Referenced Files

	F5124712: D14468.id47594.diff
	Thu, Apr 3, 8:44 PM

	F5124553: D14468.id47594.diff
	Thu, Apr 3, 8:20 PM

	Unknown Object (File)
	Wed, Apr 2, 10:32 PM

	Unknown Object (File)
	Wed, Apr 2, 4:32 AM

	Unknown Object (File)
	Tue, Apr 1, 10:52 PM

	Unknown Object (File)
	Tue, Apr 1, 3:28 AM

	Unknown Object (File)
	Sun, Mar 30, 10:50 AM

	Unknown Object (File)
	Sat, Mar 29, 2:55 PM

View All 18 Files

Subscribers

Details

Reviewers

Commits

rCOMM7be92c55a5d9: [native] Add MediaModule expo module

Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Just some boilerplate, I based the module structure on existing expo modules in the app.

Test Plan

Build the app

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Thu, Mar 20, 4:30 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:30 AM

angelika added a child revision: D14469: [android] Implement getVideoInfo() function on Android.Thu, Mar 20, 4:32 AM

Harbormaster completed remote builds in B33775: Diff 47479.Thu, Mar 20, 4:49 AM

angelika edited the summary of this revision. (Show Details)Thu, Mar 20, 4:50 AM

angelika published this revision for review.Thu, Mar 20, 5:55 AM

bartek accepted this revision.Fri, Mar 21, 1:40 AM

This revision is now accepted and ready to land.Fri, Mar 21, 1:40 AM

Rebase

Harbormaster completed remote builds in B33826: Diff 47544.Tue, Mar 25, 10:18 PM

Closed by commit rCOMM7be92c55a5d9: [native] Add MediaModule expo module (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM7be92c55a5d9: [native] Add MediaModule expo module.

Revision Contents
Changeset List

Path

Size

native/

expo-modules/

comm-expo-package/

android/

src/

main/

java/

app/

comm/

android/

media/

18 lines

expo-module.config.json

10 lines

ios/

MediaModule.swift

13 lines

utils/

media-module.js

6 lines

Diff 47479

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt

	Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines		:root {
	--app-list-icon-enabled-color: var(--success-primary);			--app-list-icon-enabled-color: var(--success-primary);
	--app-list-icon-disabled-color: var(--shades-white-80);			--app-list-icon-disabled-color: var(--shades-white-80);
	--account-settings-label: var(--shades-black-60);			--account-settings-label: var(--shades-black-60);
	--account-button-color: var(--violet-dark-100);			--account-button-color: var(--violet-dark-100);
	--chat-thread-list-menu-color: var(--shades-white-60);			--chat-thread-list-menu-color: var(--shades-white-60);
	--chat-thread-list-menu-bg: var(--shades-black-80);			--chat-thread-list-menu-bg: var(--shades-black-80);
	--chat-thread-list-menu-active-color: var(--shades-white-60);			--chat-thread-list-menu-active-color: var(--shades-white-60);
	--chat-thread-list-menu-active-bg: var(--shades-black-90);			--chat-thread-list-menu-active-bg: var(--shades-black-90);
				--search-clear-color: var(--shades-white-100);
				--search-clear-bg: var(--shades-black-70);
				--search-input-color: var(--shades-white-100);
				--search-input-placeholder: var(--shades-black-60);
				--search-icon-color: var(--shades-black-60);
	}			}

native/expo-modules/comm-expo-package/expo-module.config.json

	Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines		:root {
	--app-list-icon-enabled-color: var(--success-primary);			--app-list-icon-enabled-color: var(--success-primary);
	--app-list-icon-disabled-color: var(--shades-white-80);			--app-list-icon-disabled-color: var(--shades-white-80);
	--account-settings-label: var(--shades-black-60);			--account-settings-label: var(--shades-black-60);
	--account-button-color: var(--violet-dark-100);			--account-button-color: var(--violet-dark-100);
	--chat-thread-list-menu-color: var(--shades-white-60);			--chat-thread-list-menu-color: var(--shades-white-60);
	--chat-thread-list-menu-bg: var(--shades-black-80);			--chat-thread-list-menu-bg: var(--shades-black-80);
	--chat-thread-list-menu-active-color: var(--shades-white-60);			--chat-thread-list-menu-active-color: var(--shades-white-60);
	--chat-thread-list-menu-active-bg: var(--shades-black-90);			--chat-thread-list-menu-active-bg: var(--shades-black-90);
				--search-clear-color: var(--shades-white-100);
				--search-clear-bg: var(--shades-black-70);
				--search-input-color: var(--shades-white-100);
				--search-input-placeholder: var(--shades-black-60);
				--search-icon-color: var(--shades-black-60);
	}			}

native/expo-modules/comm-expo-package/ios/MediaModule.swift

	Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines		:root {
	--app-list-icon-enabled-color: var(--success-primary);			--app-list-icon-enabled-color: var(--success-primary);
	--app-list-icon-disabled-color: var(--shades-white-80);			--app-list-icon-disabled-color: var(--shades-white-80);
	--account-settings-label: var(--shades-black-60);			--account-settings-label: var(--shades-black-60);
	--account-button-color: var(--violet-dark-100);			--account-button-color: var(--violet-dark-100);
	--chat-thread-list-menu-color: var(--shades-white-60);			--chat-thread-list-menu-color: var(--shades-white-60);
	--chat-thread-list-menu-bg: var(--shades-black-80);			--chat-thread-list-menu-bg: var(--shades-black-80);
	--chat-thread-list-menu-active-color: var(--shades-white-60);			--chat-thread-list-menu-active-color: var(--shades-white-60);
	--chat-thread-list-menu-active-bg: var(--shades-black-90);			--chat-thread-list-menu-active-bg: var(--shades-black-90);
				--search-clear-color: var(--shades-white-100);
				--search-clear-bg: var(--shades-black-70);
				--search-input-color: var(--shades-white-100);
				--search-input-placeholder: var(--shades-black-60);
				--search-icon-color: var(--shades-black-60);
	}			}

native/utils/media-module.js

	Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines		:root {
	--app-list-icon-enabled-color: var(--success-primary);			--app-list-icon-enabled-color: var(--success-primary);
	--app-list-icon-disabled-color: var(--shades-white-80);			--app-list-icon-disabled-color: var(--shades-white-80);
	--account-settings-label: var(--shades-black-60);			--account-settings-label: var(--shades-black-60);
	--account-button-color: var(--violet-dark-100);			--account-button-color: var(--violet-dark-100);
	--chat-thread-list-menu-color: var(--shades-white-60);			--chat-thread-list-menu-color: var(--shades-white-60);
	--chat-thread-list-menu-bg: var(--shades-black-80);			--chat-thread-list-menu-bg: var(--shades-black-80);
	--chat-thread-list-menu-active-color: var(--shades-white-60);			--chat-thread-list-menu-active-color: var(--shades-white-60);
	--chat-thread-list-menu-active-bg: var(--shades-black-90);			--chat-thread-list-menu-active-bg: var(--shades-black-90);
				--search-clear-color: var(--shades-white-100);
				--search-clear-bg: var(--shades-black-70);
				--search-input-color: var(--shades-white-100);
				--search-input-placeholder: var(--shades-black-60);
				--search-icon-color: var(--shades-black-60);
	}			}