Page MenuHomePhabricator
Differential D14469

[android] Implement getVideoInfo() function on Android
ClosedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:32 AM.
Tags
None
Referenced Files
F5106934: D14469.id47546.diff
Tue, Apr 1, 9:50 AM
Unknown Object (File)
Mon, Mar 31, 10:10 PM
Unknown Object (File)
Mon, Mar 31, 7:51 PM
Unknown Object (File)
Mon, Mar 31, 1:47 PM
Unknown Object (File)
Sun, Mar 30, 6:24 PM
Unknown Object (File)
Sun, Mar 30, 4:12 AM
Unknown Object (File)
Sat, Mar 29, 5:43 PM
Unknown Object (File)
Sat, Mar 29, 1:27 AM
View All 19 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMM1775e7d6d37f: [android] Implement getVideoInfo() function on Android
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Depends on D14468

Test Plan

Try to send a video and see video info

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Thu, Mar 20, 4:32 AM
angelika held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:32 AM
angelika added a child revision: D14470: [ios] Implement getVideoInfo() function on iOS.Thu, Mar 20, 4:33 AM
Harbormaster completed remote builds in B33776: Diff 47480.Thu, Mar 20, 4:50 AM
angelika added inline comments.Thu, Mar 20, 4:54 AM
native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt
68

I don't know what format is in the original ffmpeg implementation. It's not documented anywhere and when I've tested it the ffmpeg implementation didn't even return it. Because it's later compared to "mp4" to check if format is correct I'm just returning the file extension. We can run more complicated checks but I think it's good enough for our usecase.

angelika published this revision for review.Thu, Mar 20, 5:55 AM
bartek accepted this revision.Fri, Mar 21, 1:42 AM
bartek added inline comments.
native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt
68

I agree, let's keep it this way for now

This revision is now accepted and ready to land.Fri, Mar 21, 1:42 AM
angelika updated this revision to Diff 47545.Tue, Mar 25, 9:59 PM

Rebase

Harbormaster completed remote builds in B33827: Diff 47545.Tue, Mar 25, 10:18 PM
Closed by commit rCOMM1775e7d6d37f: [android] Implement getVideoInfo() function on Android (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM1775e7d6d37f: [android] Implement getVideoInfo() function on Android.

Revision Contents
Changeset List

PathSize
native/
expo-modules/
comm-expo-package/
android/
src/
main/
java/
app/
comm/
android/
media/
70 lines

Diff 47480

View Options

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt

Show All 37 Linesexport type OutboundP2PMessage = {
+supportsAutoRetry: boolean, +supportsAutoRetry: boolean,
}; };
export type SQLiteAPI = { export type SQLiteAPI = {
// read operations // read operations
+getAllInboundP2PMessage: () => Promise<InboundP2PMessage[]>, +getAllInboundP2PMessage: () => Promise<InboundP2PMessage[]>,
+getAllOutboundP2PMessage: () => Promise<OutboundP2PMessage[]>, +getAllOutboundP2PMessage: () => Promise<OutboundP2PMessage[]>,
+getRelatedMessages: (messageID: string) => Promise<ClientDBMessageInfo[]>, +getRelatedMessages: (messageID: string) => Promise<ClientDBMessageInfo[]>,
+getOutboundP2PMessagesByID: (
ids: $ReadOnlyArray<string>,
) => Promise<$ReadOnlyArray<OutboundP2PMessage>>,
kamilUnsubmitted
Done
Inline Actions

I prefer to return OutboundP2PMessage[] here but up to you

kamil: I prefer to return `OutboundP2PMessage[]` here but up to you
tomekAuthorUnsubmitted
Done
Inline Actions

OutboundP2PMessage[] syntax is recommended to be avoided by Flow. But we can use Array<OutboundP2PMessage>

tomek: `OutboundP2PMessage[]` syntax is recommended to be avoided by Flow. But we can use…
// write operations // write operations
+removeInboundP2PMessages: (ids: $ReadOnlyArray<string>) => Promise<void>, +removeInboundP2PMessages: (ids: $ReadOnlyArray<string>) => Promise<void>,
+markOutboundP2PMessageAsSent: ( +markOutboundP2PMessageAsSent: (
messageID: string, messageID: string,
deviceID: string, deviceID: string,
) => Promise<void>, ) => Promise<void>,
+removeOutboundP2PMessagesOlderThan: ( +removeOutboundP2PMessagesOlderThan: (
Show All 9 Lines